Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2311853002: Revert of [gn] Switch win clang bot to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ ) Reason for revert: Fails compilation: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang Original issue's description: > [gn] Switch win clang bot to gn > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 > Cr-Commit-Position: refs/heads/master@{#39156} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e Cr-Commit-Position: refs/heads/master@{#39158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/mb/mb_config.pyl View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of [gn] Switch win clang bot to gn
4 years, 3 months ago (2016-09-05 11:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311853002/1
4 years, 3 months ago (2016-09-05 11:07:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:07:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e Cr-Commit-Position: refs/heads/master@{#39158}
4 years, 3 months ago (2016-09-05 11:08:25 UTC) #7
Michael Achenbach
4 years, 3 months ago (2016-09-06 08:58:41 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2312093002/ by machenbach@chromium.org.

The reason for reverting is: Trying reland with plugin switched off..

Powered by Google App Engine
This is Rietveld 408576698