Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2311803002:
Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (Closed)
|
Created:
4 years, 3 months ago by magjed_chromium Modified:
4 years, 3 months ago CC:
chromium-reviews, bsalomon Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ )
Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit)
https://codereview.chromium.org/2309653002
Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit)
https://codereview.chromium.org/2305203002
Reason for revert:
This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders:
https://build.chromium.org/p/chromium/builders/Mac
https://build.chromium.org/p/chromium/builders/Linux%20x64
The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/
Original issue's description:
> Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit).
>
> https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6
>
> $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s'
> 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> TBR=bsalomon@google.com
>
> Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780
> Cr-Commit-Position: refs/heads/master@{#416414}
TBR=bsalomon@google.com,skia-deps-roller@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/dca6c398ed7224d8876166854fa3d3bf03c118ac
Cr-Commit-Position: refs/heads/master@{#416531}
Patch Set 1 #Patch Set 2 : Revert subsequent rolls #Patch Set 3 : Skip test_runner.pydeps #Messages
Total messages: 15 (8 generated)
Created Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit).
Description was changed from ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ========== to ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ==========
The CQ bit was checked by magjed@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ========== to ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/ Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by magjed@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by magjed@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/ Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ========== to ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/ Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/ Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. ========== to ========== Revert of Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2307183002/ ) Revert of Roll src/third_party/skia/ af92a7f85..3b4bc7465 (1 commit) https://codereview.chromium.org/2309653002 Revert of Roll src/third_party/skia/ 54682e856..af92a7f85 (1 commit) https://codereview.chromium.org/2305203002 Reason for revert: This roll introduced two static initializers (gAdobeRGB and gSRGB) which are causing size regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Mac https://build.chromium.org/p/chromium/builders/Linux%20x64 The Skia CL that is causing trouble is: https://codereview.chromium.org/2302413002/ Original issue's description: > Roll src/third_party/skia/ 39f7a10a0..54682e856 (1 commit). > > https://chromium.googlesource.com/skia.git/+log/39f7a10a04a9..54682e856cb6 > > $ git log 39f7a10a0..54682e856 --date=short --no-merges --format='%ad %ae %s' > 2016-09-02 msarett Delete SkColorSpace::kUnknown_Named, remove fNamed field > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=bsalomon@google.com > > Committed: https://crrev.com/3c9bc129478c05bb53e77326000e8e4293222780 > Cr-Commit-Position: refs/heads/master@{#416414} TBR=bsalomon@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/dca6c398ed7224d8876166854fa3d3bf03c118ac Cr-Commit-Position: refs/heads/master@{#416531} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dca6c398ed7224d8876166854fa3d3bf03c118ac Cr-Commit-Position: refs/heads/master@{#416531} |
