Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 23118005: sys/signal.h: Declare kill/sigset/etc under nacl (Closed)

Created:
7 years, 4 months ago by Sam Clegg
Modified:
7 years, 3 months ago
Reviewers:
Mark Seaborn, binji
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Visibility:
Public.

Description

sys/signal.h: Declare kill/sigset/etc under nacl These functions already exist in libnosys, and in glibc headers and libc, and we want to override them in nacl_io. TEST= toolchain trybots BUG= https://code.google.com/p/nativeclient/issues/detail?id=3628 R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=92eab3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M newlib/libc/include/sys/signal.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
7 years, 4 months ago (2013-08-22 19:50:16 UTC) #1
Mark Seaborn
LGTM
7 years, 4 months ago (2013-08-22 19:51:22 UTC) #2
Mark Seaborn
On 2013/08/22 19:51:22, Mark Seaborn wrote: > LGTM Ping -- can you commit this to ...
7 years, 3 months ago (2013-09-12 00:13:26 UTC) #3
Sam Clegg
7 years, 3 months ago (2013-09-12 00:21:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r92eab3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698