ui/PRESUBMIT.py - Issue 2311783002: Re-enable PRESUBMIT check for empty unique_ptr<> rvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/PRESUBMIT.py

Issue 2311783002: Re-enable PRESUBMIT check for empty unique_ptr<> rvalue (Closed)

Patch Set: Fix it for real Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/PRESUBMIT.py

diff --git a/ui/PRESUBMIT.py b/ui/PRESUBMIT.py

index 4ee1ec87e3a7a8e181fea6606c602131c63c68ef..e69858bfc2c623b4fdaefc622d78c947e3a45087 100644

--- a/ui/PRESUBMIT.py

+++ b/ui/PRESUBMIT.py

@@ -36,10 +36,10 @@ def CheckUniquePtr(input_api, output_api,

# TODO(sky): this incorrectly catches templates. Fix and reenable.

sky 2016/09/06 18:19:17 Nuke.

Adam Rice 2016/09/07 02:44:09 Done.

# Disallow:

# std::unique_ptr<T>()

sky 2016/09/06 18:19:17 Update

Adam Rice 2016/09/07 02:44:09 I don't know how to update this. It looks correct

- # if input_api.re.search(r'\bstd::unique_ptr<.*?>\(\)', line):

- # errors.append(output_api.PresubmitError(

- # '%s:%d uses std::unique_ptr<T>(). Use nullptr instead.' %

- # (f.LocalPath(), line_number)))

+ if input_api.re.search(r'\bstd::unique_ptr<[^<>]+>\(\)', line):

+ errors.append(output_api.PresubmitError(

+ '%s:%d uses std::unique_ptr<T>(). Use nullptr instead.' %

+ (f.LocalPath(), line_number)))

return errors

« no previous file with comments | « no previous file | ui/display/chromeos/display_configurator_unittest.cc » ('j') | no next file with comments »