Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 231173005: Revert of Added event to networkingPrivate extension that portal detection is completed. (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou, ygorshenin1
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Revert of Added event to networkingPrivate extension that portal detection is completed. (https://codereview.chromium.org/225413005/) Reason for revert: Fails compile on Chromium Mac. errors like ../../chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:139:3:error: expected '{' or ',' bool RunNetworkingSubtest(const std::string& subtest) { link: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/1840/ Original issue's description: > Added event to networkingPrivate extension that portal detection is completed. > > BUG=354946 > TEST=ExtensionNetworkingPrivateApiTest.* > R=yoz@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262736 TBR=yoz@chromium.org,ygorshenin@chromium.org NOTREECHECKS=true NOTRY=true BUG=354946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -171 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 8 chunks +9 lines, -68 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc View 7 chunks +2 lines, -63 lines 0 comments Download
M chrome/common/extensions/api/networking_private.json View 2 chunks +3 lines, -18 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking/test.js View 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Added event to networkingPrivate extension that portal detection is completed.
6 years, 8 months ago (2014-04-09 18:00:09 UTC) #1
tapted
The CQ bit was unchecked by tapted@chromium.org
6 years, 8 months ago (2014-04-09 18:00:33 UTC) #2
tapted
6 years, 8 months ago (2014-04-09 18:01:57 UTC) #3
lost the revert race ;)

unchecked CQ && closing.

Powered by Google App Engine
This is Rietveld 408576698