chrome/browser/ui/views/pdf_password_dialog.cc - Issue 231173004: [WebModal] Rename NativeWebContentsModalDialogManager to SingleWebContentsDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/pdf_password_dialog.cc

Issue 231173004: [WebModal] Rename NativeWebContentsModalDialogManager to SingleWebContentsDialogManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add gtk Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/login_prompt_views.cc ('k') | chrome/browser/ui/views/signed_certificate_timestamps_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/pdf_password_dialog.cc

diff --git a/chrome/browser/ui/views/pdf_password_dialog.cc b/chrome/browser/ui/views/pdf_password_dialog.cc

index 0d5e6565bd4e19c61d9dcf3648c667a3088f840e..d49ab2b7bcf16623a17ceb9a68c3ac05d28bd10d 100644

--- a/chrome/browser/ui/views/pdf_password_dialog.cc

+++ b/chrome/browser/ui/views/pdf_password_dialog.cc

@@ -74,7 +74,8 @@ PDFPasswordDialogViews::PDFPasswordDialogViews(

DCHECK(modal_delegate);

dialog_ = views::Widget::CreateWindowAsFramelessChild(

this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView());

- web_contents_modal_dialog_manager->ShowDialog(dialog_->GetNativeView());

+ web_contents_modal_dialog_manager->ShowWebModalDialog(

Ben Goodger (Google) 2014/04/10 23:55:07 sorry to give you the runaround but could this be

Greg Billock 2014/04/11 18:34:45 Yes, that's better. will adjust.

+ dialog_->GetNativeView());

}

PDFPasswordDialogViews::~PDFPasswordDialogViews() {

« no previous file with comments | « chrome/browser/ui/views/login_prompt_views.cc ('k') | chrome/browser/ui/views/signed_certificate_timestamps_views.cc » ('j') | no next file with comments »