Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231173004: [WebModal] Rename NativeWebContentsModalDialogManager to SingleWebContentsDialogManager. (Closed)

Created:
6 years, 8 months ago by Greg Billock
Modified:
6 years, 8 months ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, benquan, Ilya Sherman, dyu1, chromium-apps-reviews_chromium.org, dkrahn+watch_chromium.org, benjhayden+dwatch_chromium.org, Dane Wallinga, oshima+watch_chromium.org, tfarina, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[WebModal] Rename NativeWebContentsModalDialogManager to SingleWebContentsDialogManager. This includes a couple of other method name updates as well. R=wittman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263866

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add file #

Patch Set 3 : Actual rename #

Total comments: 2

Patch Set 4 : Add gtk #

Total comments: 2

Patch Set 5 : ShowWebModalDialog -> ShowModalDialog #

Patch Set 6 : rebase #

Patch Set 7 : constrained window test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -177 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/captive_portal_window_proxy.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 3 4 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/download/download_danger_prompt_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/pdf_password_dialog.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/signed_certificate_timestamps_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 1 2 3 4 5 5 chunks +10 lines, -10 lines 0 comments Download
M components/web_modal.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
D components/web_modal/native_web_contents_modal_dialog_manager.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
A + components/web_modal/single_web_contents_dialog_manager.h View 1 2 3 4 chunks +13 lines, -14 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.h View 1 2 3 4 6 chunks +10 lines, -11 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 1 2 3 4 5 2 chunks +5 lines, -6 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager_unittest.cc View 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Greg Billock
6 years, 8 months ago (2014-04-09 17:24:38 UTC) #1
Mike Wittman
https://codereview.chromium.org/231173004/diff/1/components/web_modal.gypi File components/web_modal.gypi (right): https://codereview.chromium.org/231173004/diff/1/components/web_modal.gypi#newcode26 components/web_modal.gypi:26: 'web_modal/single_web_contents_dialog_manager.h', Are you missing the file rename in this ...
6 years, 8 months ago (2014-04-09 21:19:10 UTC) #2
Greg Billock
https://codereview.chromium.org/231173004/diff/1/components/web_modal.gypi File components/web_modal.gypi (right): https://codereview.chromium.org/231173004/diff/1/components/web_modal.gypi#newcode26 components/web_modal.gypi:26: 'web_modal/single_web_contents_dialog_manager.h', On 2014/04/09 21:19:10, Mike Wittman wrote: > Are ...
6 years, 8 months ago (2014-04-09 22:50:25 UTC) #3
Mike Wittman
Do we care about breaking the GTK compile at this point? If so, chrome/browser/ui/gtk/web_contents_modal_dialog_manager_gtk.cc would ...
6 years, 8 months ago (2014-04-09 23:02:08 UTC) #4
Greg Billock
got gtk, although I hear the clock is ticking... https://codereview.chromium.org/231173004/diff/40001/components/web_modal/single_web_contents_dialog_manager.h File components/web_modal/single_web_contents_dialog_manager.h (right): https://codereview.chromium.org/231173004/diff/40001/components/web_modal/single_web_contents_dialog_manager.h#newcode76 components/web_modal/single_web_contents_dialog_manager.h:76: ...
6 years, 8 months ago (2014-04-10 01:12:12 UTC) #5
Mike Wittman
On 2014/04/10 01:12:12, Greg Billock wrote: > got gtk, although I hear the clock is ...
6 years, 8 months ago (2014-04-10 18:05:59 UTC) #6
Greg Billock
On 2014/04/10 18:05:59, Mike Wittman wrote: > On 2014/04/10 01:12:12, Greg Billock wrote: > > ...
6 years, 8 months ago (2014-04-10 18:52:57 UTC) #7
Ben Goodger (Google)
https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc File chrome/browser/ui/views/pdf_password_dialog.cc (right): https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc#newcode77 chrome/browser/ui/views/pdf_password_dialog.cc:77: web_contents_modal_dialog_manager->ShowWebModalDialog( sorry to give you the runaround but could ...
6 years, 8 months ago (2014-04-10 23:55:06 UTC) #8
Greg Billock
https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc File chrome/browser/ui/views/pdf_password_dialog.cc (right): https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc#newcode77 chrome/browser/ui/views/pdf_password_dialog.cc:77: web_contents_modal_dialog_manager->ShowWebModalDialog( On 2014/04/10 23:55:07, Ben Goodger (Google) wrote: > ...
6 years, 8 months ago (2014-04-11 18:34:45 UTC) #9
Greg Billock
On 2014/04/11 18:34:45, Greg Billock wrote: > https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc > File chrome/browser/ui/views/pdf_password_dialog.cc (right): > > https://codereview.chromium.org/231173004/diff/60001/chrome/browser/ui/views/pdf_password_dialog.cc#newcode77 ...
6 years, 8 months ago (2014-04-14 18:35:27 UTC) #10
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-14 21:47:30 UTC) #11
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 8 months ago (2014-04-14 21:57:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/231173004/120001
6 years, 8 months ago (2014-04-14 21:58:30 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 06:12:29 UTC) #14
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-15 06:12:29 UTC) #15
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 8 months ago (2014-04-15 14:52:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/231173004/120001
6 years, 8 months ago (2014-04-15 14:53:01 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 16:27:31 UTC) #18
Message was sent while issue was closed. 
Change committed as 263866

Powered by Google App Engine
This is Rietveld 408576698