Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 231173003: Fix for ISpy relocation. (Closed)

Created:
6 years, 8 months ago by jbudorick
Modified:
6 years, 8 months ago
Reviewers:
craigdh, baxley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : [Android] Fix for ISpy relocation. #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/ispy/client/boto_bucket.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jbudorick
6 years, 8 months ago (2014-04-09 16:48:40 UTC) #1
craigdh
lgtm https://codereview.chromium.org/231173003/diff/20001/chrome/test/ispy/client/boto_bucket.py File chrome/test/ispy/client/boto_bucket.py (right): https://codereview.chromium.org/231173003/diff/20001/chrome/test/ispy/client/boto_bucket.py#newcode12 chrome/test/ispy/client/boto_bucket.py:12: os.pardir, os.pardir, 'tools')) you need to check that ...
6 years, 8 months ago (2014-04-09 18:08:50 UTC) #2
craigdh
On 2014/04/09 18:08:50, craigdh wrote: > lgtm > > https://codereview.chromium.org/231173003/diff/20001/chrome/test/ispy/client/boto_bucket.py > File chrome/test/ispy/client/boto_bucket.py (right): > ...
6 years, 8 months ago (2014-04-09 21:13:06 UTC) #3
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 8 months ago (2014-04-09 21:14:02 UTC) #4
baxley
On 2014/04/09 21:13:06, craigdh wrote: > On 2014/04/09 18:08:50, craigdh wrote: > > lgtm > ...
6 years, 8 months ago (2014-04-09 21:14:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/231173003/40001
6 years, 8 months ago (2014-04-09 21:15:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 22:33:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-09 22:33:53 UTC) #8
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 8 months ago (2014-04-09 22:34:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/231173003/40001
6 years, 8 months ago (2014-04-09 22:35:28 UTC) #10
craigdh
On 2014/04/09 22:35:28, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-04-09 22:41:32 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 02:08:37 UTC) #12
Message was sent while issue was closed.
Change committed as 262896

Powered by Google App Engine
This is Rietveld 408576698