chrome/renderer/printing/print_web_view_helper.cc - Issue 23116003: Adds PrintingContext implementation stub for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses code review issues. Solves infinite recursion bug. Improves the interface between Java an… Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/printing/print_web_view_helper_android.cc » ('j') | printing/printing_context_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/printing/print_web_view_helper.cc

diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc

index 048f479363231ce55468a8d4dc9ede90d4957bac..0643be373e3e09d6331caf8d67a0e5d9d87e1ed8 100644

--- a/chrome/renderer/printing/print_web_view_helper.cc

+++ b/chrome/renderer/printing/print_web_view_helper.cc

@@ -1305,7 +1305,7 @@ void PrintWebViewHelper::PrintPages() {

const PrintMsg_PrintPages_Params& params = *print_pages_params_;

const PrintMsg_Print_Params& print_params = params.params;

-#if !defined(OS_CHROMEOS)

+#if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)

// TODO(vitalybuka): should be page_count or valid pages from params.pages.

// See http://crbug.com/161576

Send(new PrintHostMsg_DidGetPrintedPagesCount(routing_id(),