chrome/browser/printing/print_view_manager_base.h - Issue 23116003: Adds PrintingContext implementation stub for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.h

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses code review issues. Solves infinite recursion bug. Improves the interface between Java an… Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/tab_android_test_stubs.cc ('K') | « chrome/browser/android/tab_android_test_stubs.cc ('k') | chrome/browser/printing/print_view_manager_basic.h » ('j') | chrome/browser/printing/print_view_manager_basic.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_view_manager_base.h

diff --git a/chrome/browser/printing/print_view_manager_base.h b/chrome/browser/printing/print_view_manager_base.h

index 03a90c61269fa3b78762330bbab9aa36acfeddfb..86e6e75ca721f01e8a8cab342b82387e6d21f8c8 100644

--- a/chrome/browser/printing/print_view_manager_base.h

+++ b/chrome/browser/printing/print_view_manager_base.h

@@ -56,6 +56,9 @@ class PrintViewManagerBase : public content::NotificationObserver,

// content::WebContentsObserver implementation.

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

+ // IPC Message handlers.

+ virtual void OnPrintingFailed(int cookie);

whywhat 2013/08/16 23:31:36 Maybe we should instead observe NOTIFICATION_PRINT

Lei Zhang 2013/08/18 09:56:26 I think other people are trying to kill Notificati

private:

// content::NotificationObserver implementation.

virtual void Observe(int type,

@@ -73,7 +76,6 @@ class PrintViewManagerBase : public content::NotificationObserver,

void OnDidGetPrintedPagesCount(int cookie, int number_pages);

void OnDidGetDocumentCookie(int cookie);

void OnDidPrintPage(const PrintHostMsg_DidPrintPage_Params& params);

- void OnPrintingFailed(int cookie);

// Processes a NOTIFY_PRINT_JOB_EVENT notification.

void OnNotifyPrintJobEvent(const JobEventDetails& event_details);