printing/printed_document.cc - Issue 23116003: Adds PrintingContext implementation stub for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printed_document.cc

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds printing support for Chrome for Android. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/printed_document.cc

diff --git a/printing/printed_document.cc b/printing/printed_document.cc

index 6e912a11be9ed2b7f05df2c8a1d11074705a2e01..1e2fa11e4ba022d6b992a0b430126dec6c95ffb2 100644

--- a/printing/printed_document.cc

+++ b/printing/printed_document.cc

@@ -225,8 +225,8 @@ PrintedDocument::Immutable::Immutable(const PrintSettings& settings,

PrintedDocument::Immutable::~Immutable() {

}

-#if defined(OS_POSIX) && defined(USE_AURA)

-// This function is not used on aura linux/chromeos.

+#if defined(OS_POSIX) && (defined(USE_AURA) || defined(OS_ANDROID))

Lei Zhang 2013/08/13 23:26:37 Can you make the #if statement match the comment?

cimamoglu1 2013/08/14 16:10:36 Done.

+// This function is not used on aura linux/chromeos or android.

void PrintedDocument::RenderPrintedPage(const PrintedPage& page,

PrintingContext* context) const {

}

« chrome/renderer/printing/print_web_view_helper_linux.cc ('K') | « printing/pdf_metafile_skia.cc ('k') | printing/printing.gyp » ('j') | printing/printing.gyp » ('J')