chrome/common/print_messages.h - Issue 23116003: Adds PrintingContext implementation stub for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/print_messages.h

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds printing support for Chrome for Android. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/chrome_mock_render_thread.h » ('j') | chrome/renderer/printing/print_web_view_helper_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/print_messages.h

diff --git a/chrome/common/print_messages.h b/chrome/common/print_messages.h

index dca63c3bcfe1368635bea16a8fe837bebfc64d22..9f2bac3d141e1e3d1a7fe2ec24b8a8ba397f34fc 100644

--- a/chrome/common/print_messages.h

+++ b/chrome/common/print_messages.h

@@ -370,15 +370,16 @@ IPC_SYNC_MESSAGE_ROUTED1_1(PrintHostMsg_ScriptedPrint,

PrintMsg_PrintPages_Params

/* settings chosen by the user*/)

-#if defined(USE_X11)

+#if defined(USE_X11) || defined(OS_ANDROID)

Lei Zhang 2013/08/13 23:26:37 BTW, can you change USE_X11 to OS_CHROMEOS?

cimamoglu1 2013/08/14 16:10:36 Done.

// Asks the browser to create a temporary file for the renderer to fill

// in resulting NativeMetafile in printing.

-IPC_SYNC_MESSAGE_CONTROL0_2(PrintHostMsg_AllocateTempFileForPrinting,

+IPC_SYNC_MESSAGE_CONTROL1_2(PrintHostMsg_AllocateTempFileForPrinting,

+ int /* render_view_id */, // Used only by Android.

Lei Zhang 2013/08/13 23:26:37 We can use the RenderView id on CrOS as well. Just

cimamoglu1 2013/08/14 16:10:36 Done.

base::FileDescriptor /* temp file fd */,

- int /* fd in browser*/)

+ int /* fd in browser*/) // Used only by Chrome OS.

IPC_MESSAGE_CONTROL2(PrintHostMsg_TempFileForPrintingWritten,

int /* render_view_id */,

- int /* fd in browser */)

+ int /* fd in browser */) // Used only by Chrome OS.

#endif

// Asks the browser to do print preview.