chrome/renderer/printing/print_web_view_helper_android.cc - Issue 23116003: Adds PrintingContext implementation stub for Android.

Unified Diff: chrome/renderer/printing/print_web_view_helper_android.cc

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses review issues. Adds stub methods for testshell and unittests targets Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/printing/print_web_view_helper_linux.cc » ('j') | printing/printing_context_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/printing/print_web_view_helper_android.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_android.cc b/chrome/renderer/printing/print_web_view_helper_android.cc

new file mode 100644

index 0000000000000000000000000000000000000000..62ba0dbb195f8b6360434ab1d2e87881c062f579

--- /dev/null

+++ b/chrome/renderer/printing/print_web_view_helper_android.cc

@@ -0,0 +1,7 @@

cimamoglu1 2013/08/14 20:38:10 Done.

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// All the necessary logic already lives in print_web_view_helper_linux.cc.

+// We need a separate file for Android due to build/filename_rules.gypi rules.

+#include "chrome/renderer/printing/print_web_view_helper_linux.cc"

Vitaly Buka (NO REVIEWS) 2013/08/14 16:23:42 why do you need print_web_view_helper_android.cc C

whywhat 2013/08/14 16:28:22 _linux.cc files are excluded from Android builds (

Vitaly Buka (NO REVIEWS) 2013/08/16 17:27:47 Probably better solution is to rename print_web_vi

whywhat 2013/08/16 23:31:36 Any suggestions for the name? print_web_view_helpe

cimamoglu1 2013/08/19 13:47:26 If there were a semantically meaningful name to co