chrome/renderer/printing/print_web_view_helper_android.cc - Issue 23116003: Adds PrintingContext implementation stub for Android.

Side by Side Diff: chrome/renderer/printing/print_web_view_helper_android.cc

Issue 23116003: Adds PrintingContext implementation stub for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses review issues. Adds stub methods for testshell and unittests targets Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/printing/print_web_view_helper_linux.cc » ('j') | printing/printing_context_android.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	Vitaly Buka (NO REVIEWS) 2013/08/14 16:23:42 // Copyright 2013 The Chromium Authors. All rights // Copyright 2013 The Chromium Authors. All rights reserved. cimamoglu1 2013/08/14 20:38:10 Done. Show quoted text On 2013/08/14 16:23:42, Vitaly Buka wrote: > // Copyright 2013 The Chromium Authors. All rights reserved. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // All the necessary logic already lives in print_web_view_helper_linux.cc.

	6 // We need a separate file for Android due to build/filename_rules.gypi rules.

	7 #include "chrome/renderer/printing/print_web_view_helper_linux.cc"
	Vitaly Buka (NO REVIEWS) 2013/08/14 16:23:42 why do you need print_web_view_helper_android.cc C why do you need print_web_view_helper_android.cc Can you just compile "chrome/renderer/printing/print_web_view_helper_linux.cc" ? whywhat 2013/08/14 16:28:22 _linux.cc files are excluded from Android builds ( Show quoted text On 2013/08/14 16:23:42, Vitaly Buka wrote: > why do you need print_web_view_helper_android.cc > Can you just compile "chrome/renderer/printing/print_web_view_helper_linux.cc" > ? _linux.cc files are excluded from Android builds (see build/filename_rules.gypi). Including the file locally didn't help so Cihat ended up with this workaround. Vitaly Buka (NO REVIEWS) 2013/08/16 17:27:47 Probably better solution is to rename print_web_vi Probably better solution is to rename print_web_view_helper_linux.cc and use condition in gyp file On 2013/08/14 16:28:22, whywhat wrote: Show quoted text > On 2013/08/14 16:23:42, Vitaly Buka wrote: > > why do you need print_web_view_helper_android.cc > > Can you just compile > "chrome/renderer/printing/print_web_view_helper_linux.cc" > > ? > > _linux.cc files are excluded from Android builds (see > build/filename_rules.gypi). > Including the file locally didn't help so Cihat ended up with this workaround. whywhat 2013/08/16 23:31:36 Any suggestions for the name? print_web_view_helpe Show quoted text On 2013/08/16 17:27:47, Vitaly Buka wrote: > Probably better solution is to rename print_web_view_helper_linux.cc and use > condition in gyp file Any suggestions for the name? print_web_view_helper_{common\|shared\|opensource}.cc ? Show quoted text > > On 2013/08/14 16:28:22, whywhat wrote: > > On 2013/08/14 16:23:42, Vitaly Buka wrote: > > > why do you need print_web_view_helper_android.cc > > > Can you just compile > > "chrome/renderer/printing/print_web_view_helper_linux.cc" > > > ? > > > > _linux.cc files are excluded from Android builds (see > > build/filename_rules.gypi). > > Including the file locally didn't help so Cihat ended up with this workaround. > cimamoglu1 2013/08/19 13:47:26 If there were a semantically meaningful name to co If there were a semantically meaningful name to cover all Android+Linux+Chrome OS+Posix-Mac, I'd love to choose it. But I believe this is the easiest and cleanest solution since I can't find such name unfortunately. On 2013/08/16 23:31:36, whywhat wrote: Show quoted text > On 2013/08/16 17:27:47, Vitaly Buka wrote: > > Probably better solution is to rename print_web_view_helper_linux.cc and use > > condition in gyp file > > Any suggestions for the name? > print_web_view_helper_{common\|shared\|opensource}.cc ? > > > > > On 2013/08/14 16:28:22, whywhat wrote: > > > On 2013/08/14 16:23:42, Vitaly Buka wrote: > > > > why do you need print_web_view_helper_android.cc > > > > Can you just compile > > > "chrome/renderer/printing/print_web_view_helper_linux.cc" > > > > ? > > > > > > _linux.cc files are excluded from Android builds (see > > > build/filename_rules.gypi). > > > Including the file locally didn't help so Cihat ended up with this > workaround. > > >
OLD	NEW