Improve test case naming in stateless_rejector_test

net/tools/quic/stateless_rejector_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/stateless_rejector.h"
 
 #include <memory>
 #include <vector>
 
+#include "base/strings/stringprintf.h"
 #include "net/quic/core/crypto/crypto_handshake_message.h"
 #include "net/quic/core/crypto/proof_source.h"
 #include "net/quic/core/quic_utils.h"
 #include "net/quic/test_tools/crypto_test_utils.h"
 #include "net/quic/test_tools/quic_crypto_server_config_peer.h"
 #include "net/quic/test_tools/quic_test_utils.h"
 
 using std::ostream;
 using std::string;
 using std::vector;
 
 namespace net {
 namespace test {
 namespace {
 
 const QuicConnectionId kConnectionId = 42;
 const QuicConnectionId kServerDesignateConnectionId = 24;
 
 // All four combinations of the two flags involved.
 enum FlagsMode { ENABLED, STATELESS_DISABLED, CHEAP_DISABLED, BOTH_DISABLED };
 
+const char* FlagsModeToString(FlagsMode mode) {
+  switch (mode) {
+    case ENABLED:
+      return "ENABLED";
+    case STATELESS_DISABLED:
+      return "STATELESS_DISABLED";
+    case CHEAP_DISABLED:
+      return "CHEAP_DISABLED";
+    case BOTH_DISABLED:
+      return "BOTH_DISABLED";
+  }
+}
+
 // Test various combinations of QUIC version and flag state.
 struct TestParams {
   QuicVersion version;
   FlagsMode flags;
-  friend ostream& operator<<(ostream& os, const TestParams& p) {
-    os << "{ version: " << p.version << " flags: " << p.flags << " }";
-    return os;
-  }
 };
 
+string TestParamToString(const testing::TestParamInfo<TestParams>& params) {
+  return base::StringPrintf("v%i_%s", params.param.version,
+                            FlagsModeToString(params.param.flags));
+}
+
 vector<TestParams> GetTestParams() {
   vector<TestParams> params;
   for (FlagsMode flags :
        {ENABLED, STATELESS_DISABLED, CHEAP_DISABLED, BOTH_DISABLED}) {
     for (QuicVersion version : AllSupportedVersions()) {
       TestParams param;
       param.version = version;
       param.flags = flags;
       params.push_back(param);
     }
@@ skipping 72 matching lines @@
   // Values used in CHLO messages
   string scid_hex_;
   string nonc_hex_;
   string pubs_hex_;
   string ver_hex_;
   string stk_hex_;
 };
 
 INSTANTIATE_TEST_CASE_P(Flags,
                         StatelessRejectorTest,
-                        ::testing::ValuesIn(GetTestParams()));
+                        ::testing::ValuesIn(GetTestParams()),
+                        TestParamToString);
 
 TEST_P(StatelessRejectorTest, InvalidChlo) {
   // clang-format off
   const CryptoHandshakeMessage client_hello = CryptoTestUtils::Message(
       "CHLO",
       "PDMD", "X509",
       "COPT", "SREJ",
       nullptr);
   // clang-format on
   rejector_.OnChlo(GetParam().version, kConnectionId,
@@ skipping 89 matching lines @@
   if (GetParam().flags != ENABLED || GetParam().version <= QUIC_VERSION_32) {
     EXPECT_EQ(StatelessRejector::UNSUPPORTED, rejector_.state());
     return;
   }
   EXPECT_EQ(StatelessRejector::ACCEPTED, rejector_.state());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net