Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 231153003: Added backround-repeat-x and -y as keyword properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added test cases. Reworked test style as requested. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/backgrounds/background-repeat-computed-style-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 declaration->addParsedProperty(CSSProperty(propertyId, value.release(), impo rtant)); 360 declaration->addParsedProperty(CSSProperty(propertyId, value.release(), impo rtant));
361 return true; 361 return true;
362 } 362 }
363 363
364 bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int valueID, const CSSParserContext& parserContext) 364 bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int valueID, const CSSParserContext& parserContext)
365 { 365 {
366 if (!valueID) 366 if (!valueID)
367 return false; 367 return false;
368 368
369 switch (propertyId) { 369 switch (propertyId) {
370 case CSSPropertyBackgroundRepeatX: // repeat | no-repeat | inherit
371 case CSSPropertyBackgroundRepeatY: // repeat | no-repeat | inherit
372 if (valueID == CSSValueRepeat || valueID == CSSValueNoRepeat)
373 return true;
374 break;
370 case CSSPropertyBorderCollapse: // collapse | separate | inherit 375 case CSSPropertyBorderCollapse: // collapse | separate | inherit
371 if (valueID == CSSValueCollapse || valueID == CSSValueSeparate) 376 if (valueID == CSSValueCollapse || valueID == CSSValueSeparate)
372 return true; 377 return true;
373 break; 378 break;
374 case CSSPropertyBorderTopStyle: // <border-style> | inherit 379 case CSSPropertyBorderTopStyle: // <border-style> | inherit
375 case CSSPropertyBorderRightStyle: // Defined as: none | hidden | dotted | da shed | 380 case CSSPropertyBorderRightStyle: // Defined as: none | hidden | dotted | da shed |
376 case CSSPropertyBorderBottomStyle: // solid | double | groove | ridge | inse t | outset 381 case CSSPropertyBorderBottomStyle: // solid | double | groove | ridge | inse t | outset
377 case CSSPropertyBorderLeftStyle: 382 case CSSPropertyBorderLeftStyle:
378 case CSSPropertyWebkitBorderAfterStyle: 383 case CSSPropertyWebkitBorderAfterStyle:
379 case CSSPropertyWebkitBorderBeforeStyle: 384 case CSSPropertyWebkitBorderBeforeStyle:
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 return false; 737 return false;
733 } 738 }
734 return false; 739 return false;
735 } 740 }
736 741
737 bool isKeywordPropertyID(CSSPropertyID propertyId) 742 bool isKeywordPropertyID(CSSPropertyID propertyId)
738 { 743 {
739 switch (propertyId) { 744 switch (propertyId) {
740 case CSSPropertyMixBlendMode: 745 case CSSPropertyMixBlendMode:
741 case CSSPropertyIsolation: 746 case CSSPropertyIsolation:
747 case CSSPropertyBackgroundRepeatX:
748 case CSSPropertyBackgroundRepeatY:
742 case CSSPropertyBorderBottomStyle: 749 case CSSPropertyBorderBottomStyle:
743 case CSSPropertyBorderCollapse: 750 case CSSPropertyBorderCollapse:
744 case CSSPropertyBorderLeftStyle: 751 case CSSPropertyBorderLeftStyle:
745 case CSSPropertyBorderRightStyle: 752 case CSSPropertyBorderRightStyle:
746 case CSSPropertyBorderTopStyle: 753 case CSSPropertyBorderTopStyle:
747 case CSSPropertyBoxSizing: 754 case CSSPropertyBoxSizing:
748 case CSSPropertyCaptionSide: 755 case CSSPropertyCaptionSide:
749 case CSSPropertyClear: 756 case CSSPropertyClear:
750 case CSSPropertyDirection: 757 case CSSPropertyDirection:
751 case CSSPropertyDisplay: 758 case CSSPropertyDisplay:
(...skipping 1490 matching lines...) Expand 10 before | Expand all | Expand 10 after
2242 rule->setProperties(createStylePropertySet()); 2249 rule->setProperties(createStylePropertySet());
2243 clearProperties(); 2250 clearProperties();
2244 2251
2245 StyleRuleViewport* result = rule.get(); 2252 StyleRuleViewport* result = rule.get();
2246 m_parsedRules.append(rule.release()); 2253 m_parsedRules.append(rule.release());
2247 2254
2248 return result; 2255 return result;
2249 } 2256 }
2250 2257
2251 } 2258 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/backgrounds/background-repeat-computed-style-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698