Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/js_array.dart

Issue 2311513002: Fix type errors in sort(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart ('k') | pkg/dev_compiler/tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/input_sdk/private/js_array.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/js_array.dart b/pkg/dev_compiler/tool/input_sdk/private/js_array.dart
index bfb0a59a3a298d8f3876af582738e34c94b533ea..653bb86c82334e41d1596f37672e42137501e080 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/js_array.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/js_array.dart
@@ -463,7 +463,11 @@ class JSArray<E> implements List<E>, JSIndexable {
void sort([int compare(E a, E b)]) {
checkMutable('sort');
- Sort.sort(this, compare == null ? Comparable.compare : compare);
+ if (compare == null) {
+ Sort.sort(this, (a, b) => (a as Comparable).compareTo(b));
vsm 2016/09/06 21:26:07 Maybe: (a, b) => Comparable.compare(a, b); ?
Bob Nystrom 2016/09/09 00:14:21 Done.
+ } else {
+ Sort.sort(this, compare);
+ }
}
void shuffle([Random random]) {
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart ('k') | pkg/dev_compiler/tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698