Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2311473002: MD Settings: Third party VPN support (Closed)

Created:
4 years, 3 months ago by stevenjb
Modified:
4 years, 3 months ago
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Third party VPN support BUG=643729 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6917d1f6412a65cfdad1eb0a6d25ce38a6baef29 Cr-Commit-Position: refs/heads/master@{#419104}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : Rebase #

Patch Set 4 : Feedback #

Total comments: 6

Patch Set 5 : Rebase #

Patch Set 6 : Rebase + Feedback #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -16 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/compiled_resources2.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 2 3 3 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 2 3 4 5 3 chunks +129 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/compiled_resources2.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_onc_types.js View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
stevenjb
4 years, 3 months ago (2016-09-02 22:25:03 UTC) #3
michaelpg
Can you expand the description a bit so it can be scanned in changelogs? https://codereview.chromium.org/2311473002/diff/20001/ui/webui/resources/cr_elements/network/cr_onc_types.js ...
4 years, 3 months ago (2016-09-06 21:22:09 UTC) #4
stevenjb
https://codereview.chromium.org/2311473002/diff/20001/ui/webui/resources/cr_elements/network/cr_onc_types.js File ui/webui/resources/cr_elements/network/cr_onc_types.js (right): https://codereview.chromium.org/2311473002/diff/20001/ui/webui/resources/cr_elements/network/cr_onc_types.js#newcode317 ui/webui/resources/cr_elements/network/cr_onc_types.js:317: * @param {!Object} caller The caller, passed as 'this' ...
4 years, 3 months ago (2016-09-12 23:12:27 UTC) #7
michaelpg
lgtm https://codereview.chromium.org/2311473002/diff/80001/chrome/browser/resources/settings/internet_page/internet_page.js File chrome/browser/resources/settings/internet_page/internet_page.js (right): https://codereview.chromium.org/2311473002/diff/80001/chrome/browser/resources/settings/internet_page/internet_page.js#newcode121 chrome/browser/resources/settings/internet_page/internet_page.js:121: * }} event opt nit: I think the ...
4 years, 3 months ago (2016-09-15 02:35:19 UTC) #8
stevenjb
https://codereview.chromium.org/2311473002/diff/80001/chrome/browser/resources/settings/internet_page/internet_page.js File chrome/browser/resources/settings/internet_page/internet_page.js (right): https://codereview.chromium.org/2311473002/diff/80001/chrome/browser/resources/settings/internet_page/internet_page.js#newcode121 chrome/browser/resources/settings/internet_page/internet_page.js:121: * }} event On 2016/09/15 02:35:19, michaelpg wrote: > ...
4 years, 3 months ago (2016-09-15 18:01:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311473002/140001
4 years, 3 months ago (2016-09-16 03:19:00 UTC) #12
commit-bot: I haz the power
Committed patchset #7 (id:140001)
4 years, 3 months ago (2016-09-16 04:56:00 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 04:57:42 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/6917d1f6412a65cfdad1eb0a6d25ce38a6baef29
Cr-Commit-Position: refs/heads/master@{#419104}

Powered by Google App Engine
This is Rietveld 408576698