Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2311463002: [Merge to M53]arc: Enable user control for Arc package sync. (Closed)

Created:
4 years, 3 months ago by lgcheng
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53]arc: Enable user control for Arc package sync. Current Arc package sync implemetation does not support stop sync and re-enable sync without rebooting. So user control of arc package sync is not achievable. This patch re-implement sync stop and enable proper user control of arc package sync using apps checkbox in advanced sync settings. BUG=641011 , http://b/31034323, http://b/30640291, http://b/30980543 TEST=Pass sync integration test. TEST=Manual test1. Turn on apps sync settings. Enable Arc and install package. Nuke Arc then enable arc. Package restored. TEST=Manual test2. Turn on apps sync settings. Enable Arc and install package. Turn off apps sync settings and then nuke Arc. Then enable arc. Package not restored. Then turn on apps sync settings. Package restored. TBR=stevenjb@chromium.org, pavely@chromium.org Review-Url: https://codereview.chromium.org/2277593002 Cr-Commit-Position: refs/heads/master@{#414277} (cherry picked from commit 9b98997de0b7f4fa5054ac7c9cc5b5778a09e2c1) Committed: https://chromium.googlesource.com/chromium/src/+/a64fbac37a6616c25eed4d47fff1e8587bdd68c4

Patch Set 1 #

Patch Set 2 : arc: Enable user control for Arc package sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -9 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 2 chunks +55 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/sync_prefs_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311463002/20001
4 years, 3 months ago (2016-09-02 21:49:45 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-02 21:49:46 UTC) #6
Luis Héctor Chávez
4 years, 3 months ago (2016-09-02 21:57:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a64fbac37a6616c25eed4d47fff1e8587bdd68c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698