Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Issue 2311453003: [Merge to M53]arc: Add arc enable sync pref initial set up. (Closed)

Created:
4 years, 3 months ago by lgcheng
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53]arc: Add arc enable sync pref initial set up. Arc enable sync pref is false by default if user never modify sync settings. This patch enables arc sync service to start when user never manually modify sync settings. BUG=642907 , http://b/31156650 TEST=Manual test on a machine that sync settings is never modified. TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2289163003 Cr-Commit-Position: refs/heads/master@{#415748} (cherry picked from commit a9c8ea0daf53303475b32177b76938cf6b31c04d) Committed: https://chromium.googlesource.com/chromium/src/+/c952ec6aee549b6bc34bebc9a06c8392faf6d949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Luis Héctor Chávez
4 years, 3 months ago (2016-09-02 23:09:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c952ec6aee549b6bc34bebc9a06c8392faf6d949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698