Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2311413002: Super property loads and stores should throw if [[Prototype]] is null (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Super property loads and stores should throw if [[Prototype]] is null While fixing the bug, removed code duplication from super load/store runtime calls, and inlined calls of Object::ReadAbsentProperty (left over from strong mode). BUG=v8:5335 Committed: https://crrev.com/624bc966b3172c15580a62de34d0fc2750c609ab Cr-Commit-Position: refs/heads/master@{#39257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -96 lines) Patch
M src/objects.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 4 chunks +4 lines, -15 lines 0 comments Download
M src/runtime/runtime-classes.cc View 7 chunks +81 lines, -71 lines 0 comments Download
M test/mjsunit/es6/super.js View 1 chunk +32 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
adamk
4 years, 3 months ago (2016-09-06 22:55:40 UTC) #2
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-07 16:55:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311413002/1
4 years, 3 months ago (2016-09-07 17:01:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 17:14:00 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:14:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/624bc966b3172c15580a62de34d0fc2750c609ab
Cr-Commit-Position: refs/heads/master@{#39257}

Powered by Google App Engine
This is Rietveld 408576698