Laser tool blocks events from propagating.

ash/laser/laser_pointer_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ash/common/system/chromeos/palette/tools/laser_pointer_view.h"
+#include "ash/laser/laser_pointer_view.h"
 
 #include <memory>
 
 #include "ash/common/shell_window_ids.h"
-#include "ash/common/wm_root_window_controller.h"
-#include "ash/common/wm_shell.h"
-#include "ash/common/wm_window.h"
+#include "ash/laser/laser_pointer_points.h"
+#include "base/timer/timer.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkPaint.h"
+#include "ui/aura/window.h"
+#include "ui/events/event.h"
 #include "ui/gfx/canvas.h"
+#include "ui/views/widget/widget.h"
 
 namespace ash {
 namespace {
 
+// Variables for rendering the laser. Radius in DIP.
 const double kPointInitialRadius = 5;
 const double kPointFinalRadius = 0.25;
 const int kPointInitialOpacity = 200;
 const int kPointFinalOpacity = 0;
 const SkColor kPointColor = SkColorSetRGB(255, 0, 0);
 
 float DistanceBetweenPoints(const gfx::Point& point1,
                             const gfx::Point& point2) {
   return (point1 - point2).Length();
 }
 
 double LinearInterpolate(double initial_value,
                          double final_value,
                          double progress) {
   return initial_value + (final_value - initial_value) * progress;
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 
 // LaserPointerView
-LaserPointerView::LaserPointerView(base::TimeDelta life_duration)
+LaserPointerView::LaserPointerView(base::TimeDelta life_duration,
+                                   aura::Window* root_window)
     : laser_points_(life_duration) {
   widget_.reset(new views::Widget);
   views::Widget::InitParams params;
   params.type = views::Widget::InitParams::TYPE_WINDOW_FRAMELESS;
-  params.name = "LaserOverlay";
+  params.name = "Laser Overlay";
   params.accept_events = false;
   params.activatable = views::Widget::InitParams::ACTIVATABLE_NO;
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
-  WmShell::Get()
-      ->GetRootWindowForNewWindows()
-      ->GetRootWindowController()
-      ->ConfigureWidgetInitParamsForContainer(
-          widget_.get(), kShellWindowId_OverlayContainer, &params);
+  params.parent = root_window;

[James Cook, 2016/09/14 22:53:38]

I think this is wrong. I didn't notice before because of all the other things I
was commenting on.

Your widget should not be a direct parent of the root. It should go in the
overlay container, like it did before. The root window only owns containers. You
can see this by passing --ash-debug-shortcuts to chrome and hitting
ctrl-alt-shift-w to print the window hierarchy.

You need something like:

parent = Shell::GetContainer(root_window, kShellWindowId_OverlayContainer);

[sammiequon, 2016/09/16 17:35:26]

Done.

+
   widget_->Init(params);
   widget_->Show();
   widget_->SetContentsView(this);
   set_owned_by_client();
 }
 
 LaserPointerView::~LaserPointerView() {}
 
 void LaserPointerView::Stop() {
   laser_points_.Clear();
   SchedulePaint();
 }
 
+aura::Window* LaserPointerView::GetRootWindow() {
+  return widget_->GetNativeView()->GetRootWindow();
+}
+
 void LaserPointerView::AddNewPoint(const gfx::Point& new_point) {
   laser_points_.AddPoint(new_point);
   // Expand the bounding box so that it includes the radius of the points on the
   // edges.
   gfx::Rect bounding_box;
   bounding_box = laser_points_.GetBoundingBox();
   bounding_box.Offset(-kPointInitialRadius, -kPointInitialRadius);
   bounding_box.set_width(bounding_box.width() + (kPointInitialRadius * 2));
   bounding_box.set_height(bounding_box.height() + (kPointInitialRadius * 2));
   widget_->SetBounds(bounding_box);
   SchedulePaint();
 }
 
 void LaserPointerView::OnPaint(gfx::Canvas* canvas) {
   if (laser_points_.IsEmpty())
     return;
 
   SkPaint paint;
   paint.setStyle(SkPaint::kStroke_Style);
   paint.setAntiAlias(true);
   paint.setStrokeJoin(SkPaint::kBevel_Join);
 
   base::Time oldest = laser_points_.GetOldest().creation_time;
   base::Time newest = laser_points_.GetNewest().creation_time;
   gfx::Point previous_point = laser_points_.GetOldest().location;
   gfx::Point current_point;
-  gfx::Rect widget_bounds = widget_->GetWindowBoundsInScreen();
+
+  // Compute the offset of the current widget.
+  gfx::Point offset =

[James Cook, 2016/09/14 22:53:38]

how about |widget_offset| or |widget_origin| ?

[sammiequon, 2016/09/16 17:35:26]

Done.

+      widget_->GetNativeView()->GetBoundsInRootWindow().origin();
   int num_points_ = laser_points_.GetNumberOfPoints();
   int point_count = 0;
   for (const LaserPointerPoints::LaserPoint& point :
        laser_points_.laser_points()) {
     // relative_time is a value between [0,1] where 0 means the point is about
     // to be removed and 1 means that the point was just added.
     double relative_time = 1.0;
     if (oldest != newest) {
       relative_time = 1.0 - ((point.creation_time - oldest).InMillisecondsF() /
                              (newest - oldest).InMillisecondsF());
     }
 
     // Set the radius and opacity based on the distance.
     double radius = LinearInterpolate(kPointInitialRadius, kPointFinalRadius,
                                       relative_time);
 
-    gfx::Vector2d center = point.location - widget_bounds.origin();
+    gfx::Vector2d center = point.location - offset;
     current_point = gfx::Point(center.x(), center.y());
 
     // If we draw laser_points_ that are within a stroke width of each other,
     // the result will be very jagged, unless we are on the last point, then we
     // draw regardless.
     point_count++;
     float distance_threshold = float{radius * 2};
     if (DistanceBetweenPoints(previous_point, current_point) <=
             distance_threshold &&
         point_count != num_points_) {
       continue;
     }
 
     int opacity =
         int{LinearInterpolate(double{kPointInitialOpacity},
                               double{kPointFinalOpacity}, relative_time)};
     paint.setColor(SkColorSetA(kPointColor, opacity));
     paint.setStrokeWidth(radius * 2);
     canvas->DrawLine(previous_point, current_point, paint);
     previous_point = current_point;
   }
+  // Draw the last point as a circle.
   paint.setColor(SkColorSetA(kPointColor, kPointInitialOpacity));
   paint.setStyle(SkPaint::kFill_Style);
   canvas->DrawCircle(current_point, kPointInitialRadius, paint);
 }
 }  // namespace ash