Laser tool blocks events from propagating.

ash/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//ui/base/ui_features.gni")
 
 assert(use_aura)
@@ skipping 234 matching lines @@
     "common/system/chromeos/palette/palette_utils.cc",
     "common/system/chromeos/palette/palette_utils.h",
     "common/system/chromeos/palette/tools/capture_region_mode.cc",
     "common/system/chromeos/palette/tools/capture_region_mode.h",
     "common/system/chromeos/palette/tools/capture_screen_action.cc",
     "common/system/chromeos/palette/tools/capture_screen_action.h",
     "common/system/chromeos/palette/tools/create_note_action.cc",
     "common/system/chromeos/palette/tools/create_note_action.h",
     "common/system/chromeos/palette/tools/laser_pointer_mode.cc",
     "common/system/chromeos/palette/tools/laser_pointer_mode.h",
-    "common/system/chromeos/palette/tools/laser_pointer_points.cc",
-    "common/system/chromeos/palette/tools/laser_pointer_points.h",
-    "common/system/chromeos/palette/tools/laser_pointer_view.cc",
-    "common/system/chromeos/palette/tools/laser_pointer_view.h",
     "common/system/chromeos/palette/tools/magnifier_mode.cc",
     "common/system/chromeos/palette/tools/magnifier_mode.h",
     "common/system/chromeos/power/battery_notification.cc",
     "common/system/chromeos/power/battery_notification.h",
     "common/system/chromeos/power/dual_role_notification.cc",
     "common/system/chromeos/power/dual_role_notification.h",
     "common/system/chromeos/power/power_status.cc",
     "common/system/chromeos/power/power_status.h",
     "common/system/chromeos/power/power_status_view.cc",
     "common/system/chromeos/power/power_status_view.h",
@@ skipping 365 matching lines @@
     "host/ash_window_tree_host_unified.h",
     "host/ash_window_tree_host_win.cc",
     "host/ash_window_tree_host_win.h",
     "host/ash_window_tree_host_x11.cc",
     "host/ash_window_tree_host_x11.h",
     "host/root_window_transformer.h",
     "host/transformer_helper.cc",
     "host/transformer_helper.h",
     "ime/input_method_event_handler.cc",
     "ime/input_method_event_handler.h",
+    "laser/laser_pointer_controller.cc",

[James Cook, 2016/09/14 22:53:38]

These may have to go in a special if (is_chromeos) section below. You'll see if
you get linker errors on windows on trybots.

(You could also remove them with -laser/laser_pointer_controller.h below, but
conditionally adding is easier to read than conditionally removing.)

[sammiequon, 2016/09/16 17:35:26]

Done.

+    "laser/laser_pointer_controller.h",
+    "laser/laser_pointer_points.cc",
+    "laser/laser_pointer_points.h",
+    "laser/laser_pointer_view.cc",
+    "laser/laser_pointer_view.h",
     "link_handler_model.cc",
     "link_handler_model.h",
     "link_handler_model_factory.cc",
     "link_handler_model_factory.h",
     "magnifier/magnification_controller.cc",
     "magnifier/magnification_controller.h",
     "magnifier/partial_magnification_controller.cc",
     "magnifier/partial_magnification_controller.h",
     "metrics/desktop_task_switch_metric_recorder.cc",
     "metrics/desktop_task_switch_metric_recorder.h",
@@ skipping 250 matching lines @@
       "//ui/ozone",
     ]
   } else {
     sources -= [
       "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc",
       "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h",
     ]
   }
 
   if (is_chromeos) {
     deps += [

[James Cook, 2016/09/14 22:53:37]

sources += [ ...the laser stuff... ] could go here

[sammiequon, 2016/09/16 17:35:26]

Done.

       "//chromeos",
       "//chromeos:power_manager_proto",
       "//components/quirks",
       "//device/bluetooth",
 
       # TODO(msw): Remove this; only ash_with_content should depend on webkit.
       "//third_party/WebKit/public:blink_headers",
       "//third_party/qcms",
       "//ui/chromeos",
       "//ui/chromeos/resources",
       "//ui/chromeos/strings",
       "//ui/display/util",
     ]
 
     data = [
       "display/test_data/",
     ]
   } else {
     sources -= [
       "accelerators/key_hold_detector.cc",

[James Cook, 2016/09/14 22:53:38]

Ideally all these things would go in the sources += section above and be taken
out of the main list. But that's not something you should do in your CL. It
would be a nice cleanup task later.

[sammiequon, 2016/09/16 17:35:26]

Who should I file this bug for?

[James Cook, 2016/09/16 18:13:31]

Doesn't matter who.

       "accelerators/key_hold_detector.h",
       "accelerators/magnifier_key_scroller.cc",
       "accelerators/magnifier_key_scroller.h",
       "accelerators/spoken_feedback_toggler.cc",
       "accelerators/spoken_feedback_toggler.h",
+      "common/system/chromeos/palette/palette_utils.cc",
+      "common/system/chromeos/palette/palette_utils.h",
       "display/resolution_notification_controller.cc",
       "display/resolution_notification_controller.h",
       "touch/touch_transformer_controller.cc",
       "touch/touch_transformer_controller.h",
       "touch/touchscreen_util.cc",
       "touch/touchscreen_util.h",
       "virtual_keyboard_controller.cc",
       "virtual_keyboard_controller.h",
       "wm/stylus_metrics_recorder.cc",
       "wm/stylus_metrics_recorder.h",
@@ skipping 55 matching lines @@
 static_library("test_support_common") {
   testonly = true
   visibility = [ ":*" ]
   sources = [
     "common/test/material_design_controller_test_api.cc",
     "common/test/material_design_controller_test_api.h",
     "common/test/test_palette_delegate.cc",
     "common/test/test_palette_delegate.h",
     "common/test/test_volume_control_delegate.cc",
     "common/test/test_volume_control_delegate.h",
+    "laser/laser_pointer_controller_test_api.cc",
+    "laser/laser_pointer_controller_test_api.h",
+    "laser/laser_pointer_points_test_api.cc",
+    "laser/laser_pointer_points_test_api.h",
     "shell/toplevel_window.cc",
     "shell/toplevel_window.h",
     "test/ash_md_test_base.cc",
     "test/ash_md_test_base.h",
     "test/ash_test_base.cc",
     "test/ash_test_base.h",
     "test/ash_test_environment.h",
     "test/ash_test_helper.cc",
     "test/ash_test_helper.h",
     "test/ash_test_views_delegate.cc",
@@ skipping 344 matching lines @@
     "common/shelf/shelf_model_unittest.cc",
     "common/shelf/shelf_tooltip_manager_unittest.cc",
     "common/shelf/shelf_window_watcher_unittest.cc",
     "common/system/chromeos/brightness/tray_brightness_unittest.cc",
     "common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc",
     "common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc",
     "common/system/chromeos/palette/mock_palette_tool_delegate.cc",
     "common/system/chromeos/palette/mock_palette_tool_delegate.h",
     "common/system/chromeos/palette/palette_tool_manager_unittest.cc",
     "common/system/chromeos/palette/tools/create_note_unittest.cc",
-    "common/system/chromeos/palette/tools/laser_pointer_mode_test_api.cc",
-    "common/system/chromeos/palette/tools/laser_pointer_mode_test_api.h",
-    "common/system/chromeos/palette/tools/laser_pointer_points_test_api.cc",
-    "common/system/chromeos/palette/tools/laser_pointer_points_test_api.h",
-    "common/system/chromeos/palette/tools/laser_pointer_unittest.cc",
     "common/system/chromeos/palette/tools/screenshot_unittest.cc",
     "common/system/chromeos/power/power_status_unittest.cc",
     "common/system/chromeos/power/power_status_view_unittest.cc",
     "common/system/chromeos/power/tray_power_unittest.cc",
     "common/system/chromeos/screen_security/screen_tray_item_unittest.cc",
     "common/system/chromeos/session/logout_confirmation_controller_unittest.cc",
     "common/system/chromeos/session/tray_session_length_limit_unittest.cc",
     "common/system/chromeos/supervised/tray_supervised_user_unittest.cc",
     "common/system/date/date_view_unittest.cc",
     "common/system/ime/tray_ime_chromeos_unittest.cc",
@@ skipping 24 matching lines @@
     "display/screen_ash_unittest.cc",
     "display/screen_position_controller_unittest.cc",
     "display/unified_mouse_warp_controller_unittest.cc",
     "display/window_tree_host_manager_unittest.cc",
     "drag_drop/drag_drop_controller_unittest.cc",
     "drag_drop/drag_drop_tracker_unittest.cc",
     "extended_desktop_unittest.cc",
     "focus_cycler_unittest.cc",
     "frame/caption_buttons/frame_size_button_unittest.cc",
     "host/ash_window_tree_host_x11_unittest.cc",
+    "laser/laser_pointer_controller_unittest.cc",
     "magnifier/magnification_controller_unittest.cc",
     "magnifier/partial_magnification_controller_unittest.cc",
     "metrics/desktop_task_switch_metric_recorder_unittest.cc",
     "metrics/task_switch_metrics_recorder_unittest.cc",
     "metrics/task_switch_time_tracker_unittest.cc",
     "metrics/user_metrics_recorder_unittest.cc",
     "root_window_controller_unittest.cc",
     "rotator/screen_rotation_animation_unittest.cc",
     "screen_util_unittest.cc",
     "shelf/shelf_layout_manager_unittest.cc",
@@ skipping 201 matching lines @@
   if (is_win) {
     configs -= [ "//build/config/win:console" ]
     configs += [ "//build/config/win:windowed" ]
     deps += [ "//sandbox" ]
   }
 
   if (is_chromeos) {
     deps += [ "//device/bluetooth" ]
   }
 }