Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2311373002: Remove calls to deprecated MessageLoop methods in headless. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in headless. This CL (hopefully) removes all calls to these methods in headless: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=skyostil@chromium.org Committed: https://crrev.com/caf5d18c1f0719b5d6c572f82debab1ad33db204 Cr-Commit-Position: refs/heads/master@{#416897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M headless/public/util/generic_url_request_job_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 21:56:40 UTC) #5
Sami
lgtm, thank you!
4 years, 3 months ago (2016-09-07 10:03:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311373002/1
4 years, 3 months ago (2016-09-07 10:04:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 10:09:47 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 10:11:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caf5d18c1f0719b5d6c572f82debab1ad33db204
Cr-Commit-Position: refs/heads/master@{#416897}

Powered by Google App Engine
This is Rietveld 408576698