Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2311363002: Remove calls to deprecated MessageLoop methods in chromecast. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
halliwell
CC:
chromium-reviews, posciak+watch_chromium.org, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in chromecast. This CL (hopefully) removes all calls to these methods in chromecast: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=halliwell@chromium.org Committed: https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815 Cr-Commit-Position: refs/heads/master@{#416751}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -97 lines) Patch
M chromecast/base/bind_to_task_runner_unittest.cc View 11 chunks +11 lines, -10 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 21 chunks +29 lines, -28 lines 0 comments Download
M chromecast/media/cma/backend/multizone_backend_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/media/cma/base/balanced_media_task_runner_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc View 5 chunks +39 lines, -37 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 21:55:31 UTC) #5
halliwell
On 2016/09/06 21:55:31, fdoray wrote: > PTAL lgtm
4 years, 3 months ago (2016-09-06 22:15:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311363002/20001
4 years, 3 months ago (2016-09-06 22:56:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 23:05:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:09:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815
Cr-Commit-Position: refs/heads/master@{#416751}

Powered by Google App Engine
This is Rietveld 408576698