Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: webkit/renderer/compositor_bindings/web_animation_impl.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code changed as per review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/test/layer_animator_test_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/renderer/compositor_bindings/web_animation_impl.cc
diff --git a/webkit/renderer/compositor_bindings/web_animation_impl.cc b/webkit/renderer/compositor_bindings/web_animation_impl.cc
index 92d2fd46adead6c1b56b1f5abeadedd56be5ad64..ca329ecd629f03b069037e80d374d31d218327fa 100644
--- a/webkit/renderer/compositor_bindings/web_animation_impl.cc
+++ b/webkit/renderer/compositor_bindings/web_animation_impl.cc
@@ -81,18 +81,21 @@ int WebAnimationImpl::iterations() const { return animation_->iterations(); }
void WebAnimationImpl::setIterations(int n) { animation_->set_iterations(n); }
-double WebAnimationImpl::startTime() const { return animation_->start_time(); }
+double WebAnimationImpl::startTime() const {
+ return (animation_->start_time() - base::TimeTicks()).InSecondsF();
+}
void WebAnimationImpl::setStartTime(double monotonic_time) {
- animation_->set_start_time(monotonic_time);
+ animation_->set_start_time(base::TimeTicks::FromInternalValue(
+ monotonic_time * base::Time::kMicrosecondsPerSecond));
}
double WebAnimationImpl::timeOffset() const {
- return animation_->time_offset();
+ return animation_->time_offset().InSecondsF();
}
void WebAnimationImpl::setTimeOffset(double monotonic_time) {
- animation_->set_time_offset(monotonic_time);
+ animation_->set_time_offset(base::TimeDelta::FromSecondsD(monotonic_time));
}
#if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
« no previous file with comments | « ui/compositor/test/layer_animator_test_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698