cc/trees/layer_tree_host_unittest_animation.cc - Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_animation.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code Refactored as per the comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_unittest_animation.cc

diff --git a/cc/trees/layer_tree_host_unittest_animation.cc b/cc/trees/layer_tree_host_unittest_animation.cc

index aeeb4f5a54b5efc975e0d43f6d61f783f66660e0..5f8c0a80fe17cfcbce5246371efda438c4ed5a58 100644

--- a/cc/trees/layer_tree_host_unittest_animation.cc

+++ b/cc/trees/layer_tree_host_unittest_animation.cc

@@ -568,7 +568,8 @@ class LayerTreeHostAnimationTestSynchronizeAnimationStartTimes

layer_animation_controller();

Animation* animation =

controller->GetAnimation(Animation::Opacity);

- main_start_time_ = animation->start_time();

+ main_start_time_ =

+ (animation->start_time() - base::TimeTicks()).InSecondsF();

controller->RemoveAnimation(animation->id());

if (impl_start_time_ > 0.0)

@@ -586,7 +587,8 @@ class LayerTreeHostAnimationTestSynchronizeAnimationStartTimes

if (!animation)

return;

- impl_start_time_ = animation->start_time();

+ impl_start_time_ =

+ (animation->start_time() - base::TimeTicks()).InSecondsF();

controller->RemoveAnimation(animation->id());

if (main_start_time_ > 0.0)

« cc/layers/layer.cc ('K') | « cc/trees/layer_tree_host_impl.cc ('k') | ui/compositor/layer_animation_sequence.cc » ('j') | webkit/renderer/compositor_bindings/web_animation_impl.cc » ('J')