cc/layers/layer.cc - Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code Refactored as per the comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/animation/layer_animation_controller_unittest.cc ('K') | « cc/input/page_scale_animation.cc ('k') | cc/trees/layer_tree_host.cc » ('j') | webkit/renderer/compositor_bindings/web_animation_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/layer.cc

diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc

index 733ecd2dbc6d4eca593b8c0fc9a1a1d4e875677d..81c7fa5ba749d23db13a8dd56d938d7c4e44cd80 100644

--- a/cc/layers/layer.cc

+++ b/cc/layers/layer.cc

@@ -1120,7 +1120,11 @@ bool Layer::AddAnimation(scoped_ptr <Animation> animation) {

}

void Layer::PauseAnimation(int animation_id, double time_offset) {

- layer_animation_controller_->PauseAnimation(animation_id, time_offset);

+ layer_animation_controller_->PauseAnimation(

+ animation_id,

+ base::TimeTicks::FromInternalValue(time_offset *

ajuma 2014/04/24 20:41:36 The second argument to PauseAnimation should be a

Sikugu_ 2014/05/05 07:09:19 Done.

+ base::Time::kMicrosecondsPerSecond) -

+ base::TimeTicks());

SetNeedsCommit();

}