Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/animation/animation_unittest.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code Refactored as per the comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/animation/animation.cc ('K') | « cc/animation/animation_events.cc ('k') | cc/animation/layer_animation_controller.h » ('j') | cc/animation/layer_animation_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/animation_unittest.cc
diff --git a/cc/animation/animation_unittest.cc b/cc/animation/animation_unittest.cc
index 8223cee5855d10a69fa91b4155fc5f5cd81a2eec..c24891b6fce1e9e4f7648414f6fe94997cdc8916 100644
--- a/cc/animation/animation_unittest.cc
+++ b/cc/animation/animation_unittest.cc
@@ -11,6 +11,9 @@
namespace cc {
namespace {
+using base::TimeTicks;
+using base::TimeDelta;
+
scoped_ptr<Animation> CreateAnimation(int iterations, double duration) {
scoped_ptr<Animation> to_return(Animation::Create(
make_scoped_ptr(
@@ -28,234 +31,249 @@ scoped_ptr<Animation> CreateAnimation(int iterations) {
TEST(AnimationTest, TrimTimeZeroIterations) {
scoped_ptr<Animation> anim(CreateAnimation(0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(1.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
}
TEST(AnimationTest, TrimTimeOneIteration) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(2.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(2.0)));
}
TEST(AnimationTest, TrimTimeInfiniteIterations) {
scoped_ptr<Animation> anim(CreateAnimation(-1));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(0.5));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(1.5));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.5)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.5)));
}
TEST(AnimationTest, TrimTimeAlternating) {
scoped_ptr<Animation> anim(CreateAnimation(-1));
anim->set_alternates_direction(true);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(0.5));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(0.75, anim->TrimTimeToCurrentIteration(1.25));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.5)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(0.75,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.25)));
}
TEST(AnimationTest, TrimTimeStartTime) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->set_start_time(4);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(4.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(4.5));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(5.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(6.0));
+ anim->set_start_time(TimeTicks::FromSeconds(4));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(4.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(4.5)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(5.0)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(6.0)));
}
TEST(AnimationTest, TrimTimeTimeOffset) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->set_time_offset(4);
- anim->set_start_time(4);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(0.5));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1.0));
+ anim->set_time_offset(TimeDelta::FromMilliseconds(4000));
+ anim->set_start_time(TimeTicks::FromSeconds(4));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.5)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
}
TEST(AnimationTest, TrimTimeNegativeTimeOffset) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->set_time_offset(-4);
+ anim->set_time_offset(TimeDelta::FromMilliseconds(-4000));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(4.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(4.5));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(5.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(4.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(4.5)));
+ EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(5.0)));
}
TEST(AnimationTest, TrimTimePauseResume) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(0.5));
- anim->SetRunState(Animation::Paused, 0.5);
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(1024.0));
- anim->SetRunState(Animation::Running, 1024.0);
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(1024.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1024.5));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.5)));
+ anim->SetRunState(Animation::Paused, TimeTicks::FromSeconds(0.5));
+ EXPECT_EQ(0.5,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.0)));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(1024.0));
+ EXPECT_EQ(0.5,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.0)));
+ EXPECT_EQ(1,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.5)));
}
TEST(AnimationTest, TrimTimeSuspendResume) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(0.5));
- anim->Suspend(0.5);
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(1024.0));
- anim->Resume(1024);
- EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(1024.0));
- EXPECT_EQ(1, anim->TrimTimeToCurrentIteration(1024.5));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.5, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.5)));
+ anim->Suspend(TimeTicks::FromSeconds(0.5));
+ EXPECT_EQ(0.5,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.0)));
+ anim->Resume(TimeTicks::FromSeconds(1024));
+ EXPECT_EQ(0.5,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.0)));
+ EXPECT_EQ(1,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1024.5)));
}
TEST(AnimationTest, TrimTimeZeroDuration) {
scoped_ptr<Animation> anim(CreateAnimation(0, 0));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(1.0));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
}
TEST(AnimationTest, TrimTimeStarting) {
scoped_ptr<Animation> anim(CreateAnimation(1, 5.0));
- anim->SetRunState(Animation::Starting, 0.0);
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(1.0));
- anim->set_time_offset(2.0);
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(1.0));
- anim->set_start_time(1.0);
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(1.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(3.0, anim->TrimTimeToCurrentIteration(2.0));
+ anim->SetRunState(Animation::Starting, TimeTicks::FromSeconds(0.0));
+ EXPECT_EQ(0.0,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ anim->set_time_offset(TimeDelta::FromMilliseconds(2000));
+ EXPECT_EQ(2.0,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ anim->set_start_time(TimeTicks::FromSeconds(1.0));
+ EXPECT_EQ(0.0,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(1.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(3.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(2.0)));
}
TEST(AnimationTest, TrimTimeNeedsSynchronizedStartTime) {
scoped_ptr<Animation> anim(CreateAnimation(1, 5.0));
- anim->SetRunState(Animation::Running, 0.0);
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
anim->set_needs_synchronized_start_time(true);
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(1.0));
- anim->set_time_offset(2.0);
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(-1.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(1.0));
- anim->set_start_time(1.0);
+ EXPECT_EQ(0.0,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(0.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ anim->set_time_offset(TimeDelta::FromMilliseconds(2000));
+ EXPECT_EQ(2.0,
+ anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ anim->set_start_time(TimeTicks::FromSeconds(1.0));
anim->set_needs_synchronized_start_time(false);
- EXPECT_EQ(1.0, anim->TrimTimeToCurrentIteration(0.0));
- EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(1.0));
- EXPECT_EQ(3.0, anim->TrimTimeToCurrentIteration(2.0));
+ EXPECT_EQ(1.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(0.0)));
+ EXPECT_EQ(2.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(1.0)));
+ EXPECT_EQ(3.0, anim->TrimTimeToCurrentIteration(TimeTicks::FromSeconds(2.0)));
}
TEST(AnimationTest, IsFinishedAtZeroIterations) {
scoped_ptr<Animation> anim(CreateAnimation(0));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_FALSE(anim->IsFinishedAt(-1.0));
- EXPECT_TRUE(anim->IsFinishedAt(0.0));
- EXPECT_TRUE(anim->IsFinishedAt(1.0));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.0)));
}
TEST(AnimationTest, IsFinishedAtOneIteration) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_FALSE(anim->IsFinishedAt(-1.0));
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- EXPECT_TRUE(anim->IsFinishedAt(1.0));
- EXPECT_TRUE(anim->IsFinishedAt(2.0));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(2.0)));
}
TEST(AnimationTest, IsFinishedAtInfiniteIterations) {
scoped_ptr<Animation> anim(CreateAnimation(-1));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- EXPECT_FALSE(anim->IsFinishedAt(0.5));
- EXPECT_FALSE(anim->IsFinishedAt(1.0));
- EXPECT_FALSE(anim->IsFinishedAt(1.5));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.5)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.5)));
}
TEST(AnimationTest, IsFinishedNegativeTimeOffset) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->set_time_offset(-0.5);
- anim->SetRunState(Animation::Running, 0.0);
+ anim->set_time_offset(TimeDelta::FromMilliseconds(-500));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
- EXPECT_FALSE(anim->IsFinishedAt(-1.0));
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- EXPECT_FALSE(anim->IsFinishedAt(0.5));
- EXPECT_FALSE(anim->IsFinishedAt(1.0));
- EXPECT_TRUE(anim->IsFinishedAt(1.5));
- EXPECT_TRUE(anim->IsFinishedAt(2.0));
- EXPECT_TRUE(anim->IsFinishedAt(2.5));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.5)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.5)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(2.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(2.5)));
}
TEST(AnimationTest, IsFinishedPositiveTimeOffset) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->set_time_offset(0.5);
- anim->SetRunState(Animation::Running, 0.0);
+ anim->set_time_offset(TimeDelta::FromMilliseconds(500));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
- EXPECT_FALSE(anim->IsFinishedAt(-1.0));
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- EXPECT_TRUE(anim->IsFinishedAt(0.5));
- EXPECT_TRUE(anim->IsFinishedAt(1.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(-1.0)));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.5)));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(1.0)));
}
TEST(AnimationTest, IsFinishedAtNotRunning) {
scoped_ptr<Animation> anim(CreateAnimation(0));
- anim->SetRunState(Animation::Running, 0.0);
- EXPECT_TRUE(anim->IsFinishedAt(0.0));
- anim->SetRunState(Animation::Paused, 0.0);
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- anim->SetRunState(Animation::WaitingForTargetAvailability, 0.0);
- EXPECT_FALSE(anim->IsFinishedAt(0.0));
- anim->SetRunState(Animation::Finished, 0.0);
- EXPECT_TRUE(anim->IsFinishedAt(0.0));
- anim->SetRunState(Animation::Aborted, 0.0);
- EXPECT_TRUE(anim->IsFinishedAt(0.0));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ anim->SetRunState(Animation::Paused, TimeTicks::FromSeconds(0.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ anim->SetRunState(Animation::WaitingForTargetAvailability,
+ TimeTicks::FromSeconds(0.0));
+ EXPECT_FALSE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ anim->SetRunState(Animation::Finished, TimeTicks::FromSeconds(0.0));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
+ anim->SetRunState(Animation::Aborted, TimeTicks::FromSeconds(0.0));
+ EXPECT_TRUE(anim->IsFinishedAt(TimeTicks::FromSeconds(0.0)));
}
TEST(AnimationTest, IsFinished) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->SetRunState(Animation::Running, 0.0);
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::Paused, 0.0);
+ anim->SetRunState(Animation::Paused, TimeTicks::FromSeconds(0.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::WaitingForTargetAvailability, 0.0);
+ anim->SetRunState(Animation::WaitingForTargetAvailability,
+ TimeTicks::FromSeconds(0.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::Finished, 0.0);
+ anim->SetRunState(Animation::Finished, TimeTicks::FromSeconds(0.0));
EXPECT_TRUE(anim->is_finished());
- anim->SetRunState(Animation::Aborted, 0.0);
+ anim->SetRunState(Animation::Aborted, TimeTicks::FromSeconds(0.0));
EXPECT_TRUE(anim->is_finished());
}
TEST(AnimationTest, IsFinishedNeedsSynchronizedStartTime) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->SetRunState(Animation::Running, 2.0);
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(2.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::Paused, 2.0);
+ anim->SetRunState(Animation::Paused, TimeTicks::FromSeconds(2.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::WaitingForTargetAvailability, 2.0);
+ anim->SetRunState(Animation::WaitingForTargetAvailability,
+ TimeTicks::FromSeconds(2.0));
EXPECT_FALSE(anim->is_finished());
- anim->SetRunState(Animation::Finished, 0.0);
+ anim->SetRunState(Animation::Finished, TimeTicks::FromSeconds(0.0));
EXPECT_TRUE(anim->is_finished());
- anim->SetRunState(Animation::Aborted, 0.0);
+ anim->SetRunState(Animation::Aborted, TimeTicks::FromSeconds(0.0));
EXPECT_TRUE(anim->is_finished());
}
TEST(AnimationTest, RunStateChangesIgnoredWhileSuspended) {
scoped_ptr<Animation> anim(CreateAnimation(1));
- anim->Suspend(0);
+ anim->Suspend(TimeTicks::FromSeconds(0));
EXPECT_EQ(Animation::Paused, anim->run_state());
- anim->SetRunState(Animation::Running, 0.0);
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
EXPECT_EQ(Animation::Paused, anim->run_state());
- anim->Resume(0);
- anim->SetRunState(Animation::Running, 0.0);
+ anim->Resume(TimeTicks::FromSeconds(0));
+ anim->SetRunState(Animation::Running, TimeTicks::FromSeconds(0.0));
EXPECT_EQ(Animation::Running, anim->run_state());
}
« cc/animation/animation.cc ('K') | « cc/animation/animation_events.cc ('k') | cc/animation/layer_animation_controller.h » ('j') | cc/animation/layer_animation_controller_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698