CC::Animations should use TimeTicks & TimeDelta to represent time

cc/animation/animation.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/animation.h"
 
 #include <cmath>
 
 #include "base/debug/trace_event.h"
 #include "base/strings/string_util.h"
@@ skipping 46 matching lines @@
 Animation::Animation(scoped_ptr<AnimationCurve> curve,
                      int animation_id,
                      int group_id,
                      TargetProperty target_property)
     : curve_(curve.Pass()),
       id_(animation_id),
       group_(group_id),
       target_property_(target_property),
       run_state_(WaitingForTargetAvailability),
       iterations_(1),
-      start_time_(0),
       direction_(Normal),
-      time_offset_(0),
       needs_synchronized_start_time_(false),
       received_finished_event_(false),
       suspended_(false),
-      pause_time_(0),
-      total_paused_time_(0),
       is_controlling_instance_(false),
       is_impl_only_(false),
       affects_active_observers_(true),
       affects_pending_observers_(true) {
 }
 
 Animation::~Animation() {
   if (run_state_ == Running || run_state_ == Paused)
-    SetRunState(Aborted, 0);
+    SetRunState(Aborted, base::TimeTicks());
 }
 
-void Animation::SetRunState(RunState run_state, double monotonic_time) {
+void Animation::SetRunState(RunState run_state,
+                            base::TimeTicks monotonic_time) {
   if (suspended_)
     return;
 
   char name_buffer[256];
   base::snprintf(name_buffer,
                  sizeof(name_buffer),
                  "%s-%d%s",
                  s_targetPropertyNames[target_property_],
                  group_,
                  is_controlling_instance_ ? "(impl)" : "");
 
   bool is_waiting_to_start = run_state_ == WaitingForTargetAvailability ||
                              run_state_ == Starting;
 
   if (is_waiting_to_start && run_state == Running) {
     TRACE_EVENT_ASYNC_BEGIN1(
         "cc", "Animation", this, "Name", TRACE_STR_COPY(name_buffer));
   }
 
   bool was_finished = is_finished();
 
   const char* old_run_state_name = s_runStateNames[run_state_];
 
   if (run_state == Running && run_state_ == Paused)
-    total_paused_time_ += monotonic_time - pause_time_;
+    total_paused_time_ += (monotonic_time - pause_time_);
   else if (run_state == Paused)
     pause_time_ = monotonic_time;
   run_state_ = run_state;
 
   const char* new_run_state_name = s_runStateNames[run_state];
 
   if (!was_finished && is_finished())
     TRACE_EVENT_ASYNC_END0("cc", "Animation", this);
 
   char state_buffer[256];
   base::snprintf(state_buffer,
                  sizeof(state_buffer),
                  "%s->%s",
                  old_run_state_name,
                  new_run_state_name);
 
   TRACE_EVENT_INSTANT2("cc",
                        "LayerAnimationController::SetRunState",
                        TRACE_EVENT_SCOPE_THREAD,
                        "Name",
                        TRACE_STR_COPY(name_buffer),
                        "State",
                        TRACE_STR_COPY(state_buffer));
 }
 
-void Animation::Suspend(double monotonic_time) {
+void Animation::Suspend(base::TimeTicks monotonic_time) {
   SetRunState(Paused, monotonic_time);
   suspended_ = true;
 }
 
-void Animation::Resume(double monotonic_time) {
+void Animation::Resume(base::TimeTicks monotonic_time) {
   suspended_ = false;
   SetRunState(Running, monotonic_time);
 }
 
-bool Animation::IsFinishedAt(double monotonic_time) const {
+bool Animation::IsFinishedAt(base::TimeTicks monotonic_time) const {
   if (is_finished())
     return true;
 
   if (needs_synchronized_start_time_)
     return false;
 
-  return run_state_ == Running &&
-         iterations_ >= 0 &&
-         iterations_ * curve_->Duration() <= (monotonic_time -
-                                              start_time() -
-                                              total_paused_time_ +
-                                              time_offset_);
+  return run_state_ == Running && iterations_ >= 0 &&
+         iterations_ * curve_->Duration() <=
+             (monotonic_time + time_offset_ - start_time_ - total_paused_time_)
+                 .InSecondsF();
 }
 
-double Animation::TrimTimeToCurrentIteration(double monotonic_time) const {
-  double trimmed = monotonic_time + time_offset_;
+double Animation::TrimTimeToCurrentIteration(

[mithro-old, 2014/05/13 09:25:30]

Why does this function still return a double? Are you leaving the conversion of
this function until later?

[Sikugu_, 2014/05/14 14:23:18]

I would like to change this once we convert the animation curve functions from 
double to Ticks/Deltas, other wise again to and fro conversion from TimeDelta to
double has to be added.

+    base::TimeTicks monotonic_time) const {
+  base::TimeTicks trimmed = monotonic_time + time_offset_;
 
   // If we're paused, time is 'stuck' at the pause time.
   if (run_state_ == Paused)
     trimmed = pause_time_;
 
   // Returned time should always be relative to the start time and should
   // subtract all time spent paused.
-  trimmed -= start_time_ + total_paused_time_;
+  trimmed -= (start_time_ - base::TimeTicks()) + total_paused_time_;

[mithro-old, 2014/05/13 09:25:30]

I don't think you need the "- base::TimeTicks()" here?

[Sikugu_, 2014/05/14 14:23:18]

We can just add or delete TimeDeltas from TimeTicks.
TimeTicks is not having a overloaded operator to subtract/add its own type.

 
   // If we're just starting or we're waiting on receiving a start time,
   // time is 'stuck' at the initial state.
   if ((run_state_ == Starting && !has_set_start_time()) ||
       needs_synchronized_start_time())
-    trimmed = time_offset_;
+    trimmed = base::TimeTicks() + time_offset_;
+
+  double trimmed_in_seconds = (trimmed - base::TimeTicks()).InSecondsF();

[mithro-old, 2014/05/13 09:25:30]

I don't see why you need to convert to seconds in this stage? Can't all the
following be done in TimeTicks/TimeDelta?

[Sikugu_, 2014/05/14 14:23:18]

fmod and division won't work well with TimeTicks.
and as of now the curve duration is not yet changed to TimeTicks.
Here it would be easy to use double.
I will take care of this in my next patch.

 
   // Return 0 if we are before the start of the animation
-  if (trimmed < 0)
+  if (trimmed_in_seconds < 0)
     return 0;
 
   // Always return zero if we have no iterations.
   if (!iterations_)
     return 0;
 
   // Don't attempt to trim if we have no duration.
   if (curve_->Duration() <= 0)
     return 0;
 
   // check if we are past active interval
   bool is_past_total_duration =
-      (iterations_ > 0 && trimmed >= curve_->Duration() * iterations_);
+      (iterations_ > 0 &&
+       trimmed_in_seconds >= curve_->Duration() * iterations_);
 
   // We need to know the current iteration if we're alternating.
   int iteration = 0;
 
   // If we are past the active interval, return iteration duration.
   if (is_past_total_duration) {
     iteration = iterations_ - 1;
-    trimmed = curve_->Duration();
+    trimmed_in_seconds = curve_->Duration();
   } else {
-    iteration = static_cast<int>(trimmed / curve_->Duration());
+    iteration = static_cast<int>(trimmed_in_seconds / curve_->Duration());
     // Calculate x where trimmed = x + n * curve_->Duration() for some positive
     // integer n.
-    trimmed = fmod(trimmed, curve_->Duration());
+    trimmed_in_seconds = fmod(trimmed_in_seconds, curve_->Duration());
   }
 
   // check if we are running the animation in reverse direction for the current
   // iteration
   bool reverse = (direction_ == Reverse) ||
                  (direction_ == Alternate && iteration % 2 == 1) ||
                  (direction_ == AlternateReverse && iteration % 2 == 0);
 
   // if we are running the animation in reverse direction, reverse the result
   if (reverse)
-    return curve_->Duration() - trimmed;
+    return curve_->Duration() - trimmed_in_seconds;
 
-  return trimmed;
+  return trimmed_in_seconds;
 }
 
 scoped_ptr<Animation> Animation::CloneAndInitialize(
     RunState initial_run_state) const {
   scoped_ptr<Animation> to_return(
       new Animation(curve_->Clone(), id_, group_, target_property_));
   to_return->run_state_ = initial_run_state;
   to_return->iterations_ = iterations_;
   to_return->start_time_ = start_time_;
   to_return->pause_time_ = pause_time_;
@@ skipping 10 matching lines @@
   // the main thread.
   if (run_state_ == Animation::Paused ||
       other->run_state_ == Animation::Paused) {
     other->run_state_ = run_state_;
     other->pause_time_ = pause_time_;
     other->total_paused_time_ = total_paused_time_;
   }
 }
 
 }  // namespace cc