CC::Animations should use TimeTicks & TimeDelta to represent time

webkit/renderer/compositor_bindings/web_animation_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/renderer/compositor_bindings/web_animation_impl.h"
 
 #include "cc/animation/animation.h"
 #include "cc/animation/animation_curve.h"
 #include "cc/animation/animation_id_provider.h"
+#include "cc/base/time_util.h"

[ajuma, 2014/05/07 17:04:42]

Please remove, since this file no longer exists in the latest patch set.

[Sikugu_, 2014/05/12 16:01:53]

Done.

 #include "third_party/WebKit/public/platform/WebAnimation.h"
 #include "third_party/WebKit/public/platform/WebAnimationCurve.h"
 #include "webkit/renderer/compositor_bindings/web_filter_animation_curve_impl.h"
 #include "webkit/renderer/compositor_bindings/web_float_animation_curve_impl.h"
 #include "webkit/renderer/compositor_bindings/web_scroll_offset_animation_curve_impl.h"
 #include "webkit/renderer/compositor_bindings/web_transform_animation_curve_impl.h"
 
 using cc::Animation;
 using cc::AnimationIdProvider;
+using cc::TimeUtil;

[ajuma, 2014/05/07 17:04:42]

Please remove.

[Sikugu_, 2014/05/12 16:01:53]

Done.

 
 using blink::WebAnimation;
 using blink::WebAnimationCurve;
 
 namespace webkit {
 
 WebAnimationImpl::WebAnimationImpl(const WebAnimationCurve& web_curve,
                                    TargetProperty target_property,
                                    int animation_id,
                                    int group_id) {
@@ skipping 45 matching lines @@
 
 blink::WebAnimation::TargetProperty WebAnimationImpl::targetProperty() const {
   return static_cast<WebAnimationImpl::TargetProperty>(
       animation_->target_property());
 }
 
 int WebAnimationImpl::iterations() const { return animation_->iterations(); }
 
 void WebAnimationImpl::setIterations(int n) { animation_->set_iterations(n); }
 
-double WebAnimationImpl::startTime() const { return animation_->start_time(); }
+double WebAnimationImpl::startTime() const {
+  return TimeUtil::TicksInSecondsF(animation_->start_time());

[ajuma, 2014/05/07 17:04:42]

TimeUtil no longer exists in the latest patch set.

[Sikugu_, 2014/05/12 16:01:53]

Done.

+}
 
 void WebAnimationImpl::setStartTime(double monotonic_time) {
-  animation_->set_start_time(monotonic_time);
+  animation_->set_start_time(base::TimeTicks::FromInternalValue(
+      monotonic_time * base::Time::kMicrosecondsPerSecond));
 }
 
 double WebAnimationImpl::timeOffset() const {
-  return animation_->time_offset();
+  return animation_->time_offset().InSecondsF();
 }
 
 void WebAnimationImpl::setTimeOffset(double monotonic_time) {
-  animation_->set_time_offset(monotonic_time);
+  animation_->set_time_offset(base::TimeDelta::FromSeconds(monotonic_time));

[ajuma, 2014/05/07 17:04:42]

FromSecondsD (or else we'll lose precision).

[Sikugu_, 2014/05/12 16:01:53]

Done.

 }
 
 #if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
 blink::WebAnimation::Direction WebAnimationImpl::direction() const {
   switch (animation_->direction()) {
     case cc::Animation::Normal:
       return DirectionNormal;
     case cc::Animation::Reverse:
       return DirectionReverse;
     case cc::Animation::Alternate:
@@ skipping 49 matching lines @@
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyOpacity, Animation::Opacity);
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyFilter, Animation::Filter);
 #if WEB_SCROLL_OFFSET_ANIMATION_CURVE_IS_DEFINED
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyScrollOffset, Animation::ScrollOffset);
 #endif
 
 }  // namespace webkit