CC::Animations should use TimeTicks & TimeDelta to represent time

webkit/renderer/compositor_bindings/web_animation_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/renderer/compositor_bindings/web_animation_impl.h"
 
 #include "cc/animation/animation.h"
 #include "cc/animation/animation_curve.h"
 #include "cc/animation/animation_id_provider.h"
 #include "third_party/WebKit/public/platform/WebAnimation.h"
@@ skipping 63 matching lines @@
 
 blink::WebAnimation::TargetProperty WebAnimationImpl::targetProperty() const {
   return static_cast<WebAnimationImpl::TargetProperty>(
       animation_->target_property());
 }
 
 int WebAnimationImpl::iterations() const { return animation_->iterations(); }
 
 void WebAnimationImpl::setIterations(int n) { animation_->set_iterations(n); }
 
-double WebAnimationImpl::startTime() const { return animation_->start_time(); }
+double WebAnimationImpl::startTime() const {
+  return animation_->ticks_inseconds(animation_->start_time());

[ajuma, 2014/04/24 20:41:36]

There's no need for a ticks_inseconds method. Just convert directly here in the
usual way (animation->start_time() - base::TimeTicks()).InSecondsF()).

[Sikugu_, 2014/05/05 07:09:19]

Done.

+}
 
 void WebAnimationImpl::setStartTime(double monotonic_time) {
-  animation_->set_start_time(monotonic_time);
+  animation_->set_start_time(base::TimeTicks::FromInternalValue(
+      monotonic_time * base::Time::kMicrosecondsPerSecond));
 }
 
 double WebAnimationImpl::timeOffset() const {
-  return animation_->time_offset();
+  return animation_->delta_inseconds(animation_->time_offset());

[ajuma, 2014/04/24 20:41:36]

There's no need for a delta_inseconds method. Use TimeDelta's conversion methods
directly.

[Sikugu_, 2014/05/05 07:09:19]

Done.

 }
 
 void WebAnimationImpl::setTimeOffset(double monotonic_time) {
-  animation_->set_time_offset(monotonic_time);
+  animation_->set_time_offset(base::TimeDelta::FromSeconds(monotonic_time));
 }
 
 bool WebAnimationImpl::alternatesDirection() const {
   return animation_->alternates_direction();
 }
 
 void WebAnimationImpl::setAlternatesDirection(bool alternates) {
   animation_->set_alternates_direction(alternates);
 }
 
@@ skipping 11 matching lines @@
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyOpacity, Animation::Opacity);
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyFilter, Animation::Filter);
 #if WEB_SCROLL_OFFSET_ANIMATION_CURVE_IS_DEFINED
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyScrollOffset, Animation::ScrollOffset);
 #endif
 
 }  // namespace webkit