Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2311313002: Make ColorStateData private to CPDF_ColorState (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make ColorStateData private to CPDF_ColorState Committed: https://pdfium.googlesource.com/pdfium/+/f40c6f122d6ddd73de21d225fca0c1734c9bdeac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -79 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.h View 2 chunks +16 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.cpp View 6 chunks +24 lines, -7 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_colorstatedata.h View 1 chunk +0 lines, -26 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_colorstatedata.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-06 18:34:06 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-06 18:38:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311313002/1
4 years, 3 months ago (2016-09-06 18:42:11 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:45:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f40c6f122d6ddd73de21d225fca0c1734c9b...

Powered by Google App Engine
This is Rietveld 408576698