Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2311303002: Revert of DevTools: remove UISourceCodeFrame from context when switching panels. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: remove UISourceCodeFrame from context when switching panels. (patchset #2 id:20001 of https://codereview.chromium.org/2287713002/ ) Reason for revert: I'll have a better one for merge. Original issue's description: > DevTools: remove UISourceCodeFrame from context when switching panels. > > BUG=640375 > > Committed: https://crrev.com/0cfac8a68fbabad4515c0a9f58c9e1dffd8c4a74 > Cr-Commit-Position: refs/heads/master@{#415105} TBR=alph@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640375 Committed: https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b Cr-Commit-Position: refs/heads/master@{#416753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 2 chunks +1 line, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pfeldman
Created Revert of DevTools: remove UISourceCodeFrame from context when switching panels.
4 years, 3 months ago (2016-09-06 18:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311303002/1
4 years, 3 months ago (2016-09-06 18:05:56 UTC) #3
alph
lgtm
4 years, 3 months ago (2016-09-06 18:53:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:07:44 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:11:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2082aee94be65ebdcc86e5b6e667537564ac837b
Cr-Commit-Position: refs/heads/master@{#416753}

Powered by Google App Engine
This is Rietveld 408576698