Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2311283002: Fixes run_vm_tests Windows shutdown problem (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes run_vm_tests Windows shutdown problem related #27250 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a695975d00b36bad0864dc7e5e3753b5bb3d8ab8

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M runtime/bin/run_vm_tests.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M runtime/platform/assert.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/platform/assert.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 3 months ago (2016-09-06 16:39:54 UTC) #2
Florian Schneider
Lgtm
4 years, 3 months ago (2016-09-06 17:00:01 UTC) #3
zra
4 years, 3 months ago (2016-09-06 17:10:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a695975d00b36bad0864dc7e5e3753b5bb3d8ab8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698