Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2418)

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 231123002: Notify about major session changes events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager.cc
diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc
index 2a248050bfa5f3846fcb22ecfabab16f13773c8f..773dada5e6171e83eed4ff49b5583ca1b5e48fa7 100644
--- a/ash/shelf/shelf_layout_manager.cc
+++ b/ash/shelf/shelf_layout_manager.cc
@@ -213,6 +213,7 @@ ShelfLayoutManager::ShelfLayoutManager(ShelfWidget* shelf)
Shell::GetInstance()->AddShellObserver(this);
Shell::GetInstance()->lock_state_controller()->AddObserver(this);
aura::client::GetActivationClient(root_window_)->AddObserver(this);
+ Shell::GetInstance()->session_state_delegate()->AddSessionStateObserver(this);
}
ShelfLayoutManager::~ShelfLayoutManager() {
@@ -223,6 +224,8 @@ ShelfLayoutManager::~ShelfLayoutManager() {
Shell::GetInstance()->RemoveShellObserver(this);
Shell::GetInstance()->lock_state_controller()->RemoveObserver(this);
aura::client::GetActivationClient(root_window_)->RemoveObserver(this);
+ Shell::GetInstance()->
+ session_state_delegate()->RemoveSessionStateObserver(this);
}
void ShelfLayoutManager::SetAutoHideBehavior(ShelfAutoHideBehavior behavior) {
@@ -740,11 +743,16 @@ void ShelfLayoutManager::UpdateBoundsAndOpacity(
status_bounds));
SessionStateDelegate* session_state_delegate =
Shell::GetInstance()->session_state_delegate();
- if (!state_.is_screen_locked &&
- (session_state_delegate->IsActiveUserSessionStarted() ||
- !keyboard_bounds_.IsEmpty())) {
- Shell::GetInstance()->SetDisplayWorkAreaInsets(
- root_window_, target_bounds.work_area_insets);
+ if (!state_.is_screen_locked) {
+ gfx::Insets insets;
+ // If user session is blocked (login to new user session or add user to
+ // the existing session - multi-profile) then give 100% of work area only if
+ // keyboard is not shown.
+ if (!session_state_delegate->IsUserSessionBlocked() ||
+ !keyboard_bounds_.IsEmpty()) {
+ insets = target_bounds.work_area_insets;
+ }
+ Shell::GetInstance()->SetDisplayWorkAreaInsets(root_window_, insets);
}
}
@@ -1165,7 +1173,7 @@ void ShelfLayoutManager::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {
// On login screen if keyboard has been just hidden, update bounds just once
// but ignore target_bounds.work_area_insets since shelf overlaps with login
// window.
- if (!session_state_delegate->IsActiveUserSessionStarted() &&
+ if (session_state_delegate->IsUserSessionBlocked() &&
keyboard_is_about_to_hide) {
Shell::GetInstance()->SetDisplayWorkAreaInsets(root_window_, gfx::Insets());
}
@@ -1200,4 +1208,12 @@ void ShelfLayoutManager::OnLockStateEvent(LockStateObserver::EventType event) {
}
}
+void ShelfLayoutManager::SessionStateChanged(
+ SessionStateDelegate::SessionState state) {
+ TargetBounds target_bounds;
+ CalculateTargetBounds(state_, &target_bounds);
+ UpdateBoundsAndOpacity(target_bounds, true, NULL);
+ UpdateVisibilityState();
+}
+
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698