Notify about major session changes events.

ash/session_state_delegate.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SESSION_STATE_DELEGATE_H_
 #define ASH_SESSION_STATE_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 27 matching lines @@
 // TODO(oshima): Replace MultiProfileIndex with BrowsreContext, bacause
 // GetUserXXX are useful for non multi profile scenario in ash_shell.
 class ASH_EXPORT SessionStateDelegate {
  public:
   // Defines the cycle direction for |CycleActiveUser|.
   enum CycleUser {
     CYCLE_TO_NEXT_USER = 0,  // Cycle to the next user.
     CYCLE_TO_PREVIOUS_USER,  // Cycle to the previous user.
   };
 
+  // Defines session state i.e. whether session is running or not and
+  // whether user session is blocked by things like lock screen and
+  // multi-profile login.
+  enum SessionState {
+    STATE_UNKNOWN = 0,

[Daniel Erat, 2014/04/10 16:30:32]

please don't add an "unknown" state; this means that every class using this enum
will need to handle it. more about this in the delegate

[Nikita (slow), 2014/04/10 17:22:51]

Done.

+
+    // When primary user login UI is shown i.e. after boot or sign out,
+    // no active user session exists yet.
+    STATE_LOGIN_PRIMARY,
+
+    // Inside user session, no blocking UI (login/lock) is shown.
+    STATE_SESSION,
+
+    // User session is active, currently is locked.
+    STATE_LOCK,

[stevenjb, 2014/04/10 17:00:06]

I'm not sure I understand this state. If this is synonymous with screen lock I
might suggest removing this state and checking screen lock directly where
necessary. Otherwise please elaborate in the comment.

[Nikita (slow), 2014/04/10 17:22:51]

Done.

+
+    // When secondary user login UI is shown i.e. other users are
+    // already logged in and is currently adding another user to the session.
+    STATE_LOGIN_SECONDARY,

[stevenjb, 2014/04/10 17:00:06]

While I hate to second guess a change in an area I'm only peripherally familiar
with, I'm also uncomfortable with adding yet another state, even in the "short"
term.

I assume there are future plans for GetSessionState(), since this CL doesn't
appear to actually use it outside of tests, but it looks to me like
LOGIN_SECONDARY is the only new "state" and we might be better off with adding
something like LOGIN_UI_STATE_{NONE|PRIMARY|SECONDARY}, rather than combining
states from different sources here? The sheer number of observers added to
SessionStateDelegateChromeos suggests to me that we are trying to do too much
with a single state; I think it will be OK to push some of that logic to the UI
code.

If we go this route then we should name these SESSION_STATE_ since, as mentioned
we already have so many login / session related states we want to reduce
confusion as much as possible.

[Nikita (slow), 2014/04/10 17:22:51]

I've dropped STATE_LOCK for now.

I would prefer to merge LOGIN_STATE into SessionStateDelegate.

[Nikita (slow), 2014/04/10 17:29:27]

Since adding this logic to ShellObserver::OnLoginStateChanged() doesn't seem
like a right place.

Next I would really like move OnLoginStateChanged() from there.

[stevenjb, 2014/04/10 17:47:55]

I agree. That's another one where we conflate "LoginState" and screen lock
state. It would be nice to eliminate ash::user::LoginStatus and use LoginState +
a separate screen lock state in the UI directly.

+  };
+
   virtual ~SessionStateDelegate() {};
 
   // Returns the browser context for the user given by |index|.
   virtual content::BrowserContext* GetBrowserContextByIndex(
       MultiProfileIndex index) = 0;
 
   // Returns the browser context associated with the window.
   virtual content::BrowserContext* GetBrowserContextForWindow(
       aura::Window* window) = 0;
 
@@ skipping 24 matching lines @@
   virtual void LockScreen() = 0;
 
   // Unlocks the screen.
   virtual void UnlockScreen() = 0;
 
   // Returns |true| if user session blocked by some overlying UI. It can be
   // login screen, lock screen or screen for adding users into multi-profile
   // session.
   virtual bool IsUserSessionBlocked() const = 0;
 
+  // Returns current session state.
+  virtual SessionState GetSessionState() const = 0;
+
   // Gets the displayed name for the user with the given |index|.
   // Note that |index| can at maximum be |NumberOfLoggedInUsers() - 1|.
   virtual const base::string16 GetUserDisplayName(
       MultiProfileIndex index) const = 0;
 
   // Gets the display email address for the user with the given |index|.
   // The display email address might contains some periods in the email name
   // as well as capitalized letters. For example: "Foo.Bar@mock.com".
   // Note that |index| can at maximum be |NumberOfLoggedInUsers() - 1|.
   virtual const std::string GetUserEmail(MultiProfileIndex index) const = 0;
@@ skipping 19 matching lines @@
   virtual void CycleActiveUser(CycleUser cycle_user) = 0;
 
   // Adds or removes sessions state observer.
   virtual void AddSessionStateObserver(SessionStateObserver* observer) = 0;
   virtual void RemoveSessionStateObserver(SessionStateObserver* observer) = 0;
 };
 
 }  // namespace ash
 
 #endif  // ASH_SESSION_STATE_DELEGATE_H_