[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes().

[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could return nullptr.

BUG=643886
Committed: https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da
Cr-Commit-Position: refs/heads/master@{#416787}

[gfhuang, 2016-09-06 16:14:54]

Description was changed from

==========
[chromecast] Add ResourceBundle::GetLocalizedResourceBytes().

BUG=643886
==========

to

==========
[chromecast] Add ResourceBundle::GetLocalizedResourceBytes() to get binary data
from locale_resources_data_.

BUG=643886
==========

[gfhuang, 2016-09-06 16:14:54]

gfhuang@chromium.org changed reviewers:
+ byungchul@chromium.org, sky@chromium.org

[sky, 2016-09-06 20:33:11]

If this is intended for images why aren't you using one of the image loading
functions?

[gfhuang, 2016-09-06 20:47:25]

On 2016/09/06 20:33:11, sky wrote:
> If this is intended for images why aren't you using one of the image loading
> functions?

Not just image, but other locale-specific binary data as well.

As you can see most of the existing caller doesn't take SkImage input.

[gfhuang, 2016-09-06 20:49:35]

Description was changed from

==========
[chromecast] Add ResourceBundle::GetLocalizedResourceBytes() to get binary data
from locale_resources_data_.

BUG=643886
==========

to

==========
[chromecast] Add ResourceBundle::GetLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

[gfhuang, 2016-09-06 20:49:35]

gfhuang@chromium.org changed reviewers:
+ dbeam@chromium.org

[byungchul, 2016-09-06 20:54:54]

lgtm

https://codereview.chromium.org/2311223003/diff/1/ui/base/resource/resource_b...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/2311223003/diff/1/ui/base/resource/resource_b...
ui/base/resource/resource_bundle.h:236: base::RefCountedMemory*
GetLocalizedResourceBytes(int message_id);
LoadLocalizedResourceBytes(int resource_id)

[sky, 2016-09-06 21:57:12]

Ok, LGTM

[gfhuang, 2016-09-06 21:59:50]

gfhuang@chromium.org changed reviewers:
+ slan@chromium.org

[gfhuang, 2016-09-06 22:00:34]

Description was changed from

==========
[chromecast] Add ResourceBundle::GetLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

to

==========
[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

[Dan Beam, 2016-09-06 22:05:50]

lgtm

[slan, 2016-09-06 22:08:14]

cast lgtm

[gfhuang, 2016-09-06 22:44:33]

The CQ bit was checked by gfhuang@chromium.org

[gfhuang, 2016-09-06 22:44:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
byungchul@chromium.org
Link to the patchset: https://codereview.chromium.org/2311223003/#ps40001
(title: "[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to to get
binary data from locale_res…")

[commit-bot: I haz the power, 2016-09-06 22:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 00:12:28]

Description was changed from

==========
[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

to

==========
[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

[commit-bot: I haz the power, 2016-09-07 00:12:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 00:15:55]

Description was changed from

==========
[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.


BUG=643886
==========

to

==========
[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data
from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could
return nullptr.

BUG=643886

Committed: https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da
Cr-Commit-Position: refs/heads/master@{#416787}
==========

[commit-bot: I haz the power, 2016-09-07 00:15:56]

Patchset 3 (id:??) landed as
https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da
Cr-Commit-Position: refs/heads/master@{#416787}