Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2311223002: Convert fast/canvas Layouttests to testharness (Closed)

Created:
4 years, 3 months ago by Abhishek Kanike
Modified:
4 years, 3 months ago
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert fast/canvas Layouttests to testharness This patch uses testharness.js asserts to test canvas winding enumeration and also checks canvas borkedness of rects with zero size. BUG=639732 Committed: https://crrev.com/e3a7b314c7a3a12c1df78938b89b52b99413b8d7 Cr-Commit-Position: refs/heads/master@{#418536}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Convert fast/canvas Layouttests to testharness #

Total comments: 8

Patch Set 3 : Refactor #

Total comments: 2

Patch Set 4 : Refactor2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html View 1 2 3 1 chunk +19 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect.html View 1 2 1 chunk +19 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
sivag
https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode9 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:9: var canvas = document.createElement("canvas"); move this to html <canvas></canvas> ...
4 years, 3 months ago (2016-09-06 12:58:45 UTC) #3
Srirama
https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect.html File third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect.html (right): https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect.html#newcode15 third_party/WebKit/LayoutTests/fast/canvas/zero-size-fill-rect.html:15: <script type="text/javascript"> remove type attribute.
4 years, 3 months ago (2016-09-06 13:27:20 UTC) #4
Abhishek Kanike
https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode9 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:9: var canvas = document.createElement("canvas"); On 2016/09/06 12:58:44, sivag wrote: ...
4 years, 3 months ago (2016-09-08 09:05:08 UTC) #5
Abhishek Kanike
Please take a look
4 years, 3 months ago (2016-09-08 09:07:27 UTC) #7
Abhishek Kanike
Please take a look
4 years, 3 months ago (2016-09-08 09:07:30 UTC) #8
Srirama
lgtm
4 years, 3 months ago (2016-09-08 10:07:25 UTC) #9
fs
https://codereview.chromium.org/2311223002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode7 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:7: <canvas></canvas> Probably good the way it was (w/ createElement.) ...
4 years, 3 months ago (2016-09-08 10:13:11 UTC) #10
Abhishek Kanike
https://codereview.chromium.org/2311223002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/20001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode7 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:7: <canvas></canvas> On 2016/09/08 10:13:10, fs wrote: > Probably good ...
4 years, 3 months ago (2016-09-14 04:33:57 UTC) #11
fs
lgtm
4 years, 3 months ago (2016-09-14 10:20:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311223002/40001
4 years, 3 months ago (2016-09-14 10:22:46 UTC) #15
Srirama
https://codereview.chromium.org/2311223002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode9 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:9: var canvas = document.createElement("canvas"); Looks like tabs were used, ...
4 years, 3 months ago (2016-09-14 10:22:47 UTC) #16
Abhishek Kanike
https://codereview.chromium.org/2311223002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html File third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html (right): https://codereview.chromium.org/2311223002/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html#newcode9 third_party/WebKit/LayoutTests/fast/canvas/winding-enumeration.html:9: var canvas = document.createElement("canvas"); On 2016/09/14 10:22:47, Srirama_OOO wrote: ...
4 years, 3 months ago (2016-09-14 10:32:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311223002/60001
4 years, 3 months ago (2016-09-14 10:48:16 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-14 11:55:36 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 11:57:31 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e3a7b314c7a3a12c1df78938b89b52b99413b8d7
Cr-Commit-Position: refs/heads/master@{#418536}

Powered by Google App Engine
This is Rietveld 408576698