Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: gyp/pdf.gyp

Issue 23112031: Update pdf.gypi to actually work with Chromium (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | gyp/pdf.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 { 3 {
4 'target_name': 'pdf', 4 'target_name': 'pdf',
5 'product_name': 'skia_pdf', 5 'product_name': 'skia_pdf',
6 'type': 'static_library', 6 'type': 'static_library',
7 'standalone_static_library': 1, 7 'standalone_static_library': 1,
8 'dependencies': [ 8 'dependencies': [
9 'skia_lib.gyp:skia_lib', 9 'skia_lib.gyp:skia_lib',
10 'zlib.gyp:zlib', 10 'zlib.gyp:zlib',
11 ], 11 ],
12 'includes': [ 12 'includes': [
13 'pdf.gypi', 13 'pdf.gypi',
14 ], 14 ],
15 'include_dirs': [ 15 'include_dirs': [
16 '../include/pdf', 16 '../include/pdf',
17 '../src/core', # needed to get SkGlyphCache.h and SkTextFormatParams.h 17 '../src/core', # needed to get SkGlyphCache.h and SkTextFormatParams.h
18 '../src/utils', # needed to get SkBitSet.h 18 '../src/utils', # needed to get SkBitSet.h
19 ], 19 ],
20 'sources': [ 20 'sources': [
21 'pdf.gypi', # Makes the gypi appear in IDEs (but does not modify the bui ld). 21 'pdf.gypi', # Makes the gypi appear in IDEs (but does not modify the bui ld).
22
23 '../src/doc/SkDocument_PDF.cpp', # Chromium does use this file
djsollen 2013/08/23 20:49:31 what will it hurt if chromium does build this?
robertphillips 2013/08/25 12:04:20 I don't know but it should probably be intentional
22 ], 24 ],
23 # This section makes all targets that depend on this target 25 # This section makes all targets that depend on this target
24 # #define SK_SUPPORT_PDF and have access to the pdf header files. 26 # #define SK_SUPPORT_PDF and have access to the pdf header files.
25 'direct_dependent_settings': { 27 'direct_dependent_settings': {
26 'defines': [ 28 'defines': [
27 'SK_SUPPORT_PDF', 29 'SK_SUPPORT_PDF',
28 ], 30 ],
29 'include_dirs': [ 31 'include_dirs': [
30 '../include/pdf', 32 '../include/pdf',
31 ], 33 ],
32 }, 34 },
33 }, 35 },
34 ], 36 ],
35 } 37 }
36 38
37 # Local Variables: 39 # Local Variables:
38 # tab-width:2 40 # tab-width:2
39 # indent-tabs-mode:nil 41 # indent-tabs-mode:nil
40 # End: 42 # End:
41 # vim: set expandtab tabstop=2 shiftwidth=2: 43 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | gyp/pdf.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698