Remove solid_color_scrollbar_thickness_dip from LayerTreeSettings.

Remove solid_color_scrollbar_thickness_dip from LayerTreeSettings.

We can get the value from Blink and currently, the two values
need to be kept the same to avoid weird rendering.  We get all the
other sizing (track bounds, margins, etc) from Blink already.

This results in no visible change on Android and will now make the
desktop overlay scrollbars fill the full width of the track.

BUG=274010
TEST=covered by existing cc_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219453

[jamesr, 2013-08-22 18:30:31]

I don't remember what the original motivation for this was - Alex?  Doing the
theme configuration through Blink is definitely a better way to go.

[aelias_OOO_until_Jul13, 2013-08-23 23:06:16]

lgtm.  This was needed to get correct appearance when I introduced it, but if it
results in no visible change today, then one of the scrollbar refactorings done
since then must have obsoleted it.

[jamesr, 2013-08-23 23:22:07]

lgtm2 then

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-08-23 23:32:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/23112020/1

[commit-bot: I haz the power, 2013-08-23 23:32:30]

Failed to apply patch for cc/layers/scrollbar_layer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: cc/layers/scrollbar_layer.cc
  |diff --git a/cc/layers/scrollbar_layer.cc b/cc/layers/scrollbar_layer.cc
  |index
a7b2eba5db13ad1a618a816075e2fc476416c35f..07e1004cdc7f6bfe8b4213a05854ddcb54346031
100644
  |--- a/cc/layers/scrollbar_layer.cc
  |+++ b/cc/layers/scrollbar_layer.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       cc/layers/scrollbar_layer.cc
Index: cc/layers/scrollbar_layer.cc
diff --git a/cc/layers/scrollbar_layer.cc b/cc/layers/scrollbar_layer.cc
index
a7b2eba5db13ad1a618a816075e2fc476416c35f..07e1004cdc7f6bfe8b4213a05854ddcb54346031
100644
--- a/cc/layers/scrollbar_layer.cc
+++ b/cc/layers/scrollbar_layer.cc
@@ -107,16 +107,7 @@ void ScrollbarLayer::PushPropertiesTo(LayerImpl* layer) {
 
   if (layer_tree_host() &&
       layer_tree_host()->settings().solid_color_scrollbars) {
-    int thickness_override =
-        layer_tree_host()->settings().solid_color_scrollbar_thickness_dip;
-    if (thickness_override != -1) {
-      scrollbar_layer->SetThumbThickness(thickness_override);
-    } else {
-      if (Orientation() == HORIZONTAL)
-        scrollbar_layer->SetThumbThickness(bounds().height());
-      else
-        scrollbar_layer->SetThumbThickness(bounds().width());
-    }
+    scrollbar_layer->SetThumbThickness(scrollbar_->ThumbThickness());
   } else {
     scrollbar_layer->SetThumbThickness(thumb_thickness_);
   }

[commit-bot: I haz the power, 2013-08-23 23:37:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/23112020/8001

[commit-bot: I haz the power, 2013-08-24 15:20:50]

Change committed as 219453