Issue 23112015: Fold wtf/Platform.h into config.h

Issue 23112015: Fold wtf/Platform.h into config.h (Closed)

Created:
7 years, 4 months ago by lgombos

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fold wtf/Platform.h into config.h and consolidate all global includes into one header. wtf/Platform.h is only included from config.h. It no longer adds value to split the global includes into 2 header files. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156660

Patch Set 1 #

Patch Set 2 : Fix wtf.gypi. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -165 lines)			Patch
M	Source/config.h	View		3 chunks	+133 lines, -2 lines	0 comments	Download
D	Source/wtf/Platform.h	View		1 chunk	+0 lines, -162 lines	0 comments	Download
M	Source/wtf/wtf.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

lgombos

This change should also avoid files including both config.h and wtf/Platfrom.h.

7 years, 4 months ago (2013-08-22 07:09:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23112015/1

7 years, 4 months ago (2013-08-22 08:29:35 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=8625

7 years, 4 months ago (2013-08-22 09:02:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23112015/15001

7 years, 4 months ago (2013-08-23 20:00:07 UTC) #6

Message was sent while issue was closed.

Change committed as 156660

Expand Messages | Collapse Messages