Reland 'Add buildbot metadata to compiler_proxy log'

Reland 'Add buildbot metadata to compiler_proxy log'

We'd like to analyze compiler proxy log. However, buildbot metadata is
missing, so sometimes hard to determine in which builder the compiler
proxy log is generated.

Append buildbot metadata to compiler_proxy log like ninja log.

The difference from the previous patch is to add '--' to gsutil.py.
Without '--', gsutil.py consumes options which is expected to pass
to gsutil itself.

Committed: https://chromium.googlesource.com/chromium/tools/build/+/3437df739c975cec15fe81d6adfed5c0fbdf2c6c

[shinyak, 2016-09-06 07:40:05]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 07:40:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shinyak, 2016-09-06 07:41:17]

shinyak@chromium.org changed reviewers:
+ tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org

[shinyak, 2016-09-06 07:41:18]

Hi,

this is the reland of https://codereview.chromium.org/2302453004/

The difference is to append '--' to gsutil.py

[commit-bot: I haz the power, 2016-09-06 07:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 07:44:24]

Dry run: This issue passed the CQ dry run.

[tikuta, 2016-09-06 07:46:14]

lgtm

[Yoshisato Yanagisawa, 2016-09-06 07:52:53]

lgtm w/ comment.

https://codereview.chromium.org/2311123002/diff/1/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2311123002/diff/1/scripts/slave/compile.py#ne...
scripts/slave/compile.py:509: help='Specify path to gsutil.py script.')
Might be better to clearly mention this is gsutil.py in depot_tools.

[shinyak, 2016-09-06 08:05:04]

https://codereview.chromium.org/2311123002/diff/1/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2311123002/diff/1/scripts/slave/compile.py#ne...
scripts/slave/compile.py:509: help='Specify path to gsutil.py script.')
On 2016/09/06 07:52:53, Yoshisato Yanagisawa wrote:
> Might be better to clearly mention this is gsutil.py in depot_tools.

Done.

[shinyak, 2016-09-06 08:05:10]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 08:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 08:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 08:12:44]

Dry run: This issue passed the CQ dry run.

[shinyak, 2016-09-06 08:13:34]

I reland this. If something bad happends, I'll revert this immediately.

[shinyak, 2016-09-06 08:13:39]

The CQ bit was checked by shinyak@chromium.org

[shinyak, 2016-09-06 08:13:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
yyanagisawa@chromium.org, tikuta@chromium.org
Link to the patchset: https://codereview.chromium.org/2311123002/#ps20001
(title: "Update --gsutil-py-path comment")

[commit-bot: I haz the power, 2016-09-06 08:13:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 08:21:01]

Description was changed from

==========
Reland 'Add buildbot metadata to compiler_proxy log'

We'd like to analyze compiler proxy log. However, buildbot metadata is
missing, so sometimes hard to determine in which builder the compiler
proxy log is generated.

Append buildbot metadata to compiler_proxy log like ninja log.

The difference from the previous patch is to add '--' to gsutil.py.
Without '--', gsutil.py consumes options which is expected to pass
to gsutil itself.
==========

to

==========
Reland 'Add buildbot metadata to compiler_proxy log'

We'd like to analyze compiler proxy log. However, buildbot metadata is
missing, so sometimes hard to determine in which builder the compiler
proxy log is generated.

Append buildbot metadata to compiler_proxy log like ninja log.

The difference from the previous patch is to add '--' to gsutil.py.
Without '--', gsutil.py consumes options which is expected to pass
to gsutil itself.

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/3437df739c975cec15fe...
==========

[commit-bot: I haz the power, 2016-09-06 08:21:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/3437df739c975cec15fe...

[shinyak, 2016-09-06 08:46:23]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2313783003/ by shinyak@chromium.org.

The reason for reverting is: -h still not working: ArgumentException: Invalid
header specifed.