Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2311093002: MD WebUI: Use dom-if to control hidden elements in <cr-toolbar> (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Use dom-if to control hidden elements in <cr-toolbar> This allows the <paper-spinner-lite> and the clear <paper-icon-button> to not be stamped until they are needed. This results in a small performance improvement (5-10ms on my Z620) across all pages which use <cr-toolbar>. In particular, this is a 1-2% improvement in MD History. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9844d8891a6c83304ba67ca07e55b7c658e958e9 Cr-Commit-Position: refs/heads/master@{#416604}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -43 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 7 chunks +23 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js View 1 2 chunks +6 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
tsergeant
PTAL!
4 years, 3 months ago (2016-09-06 05:16:39 UTC) #11
Dan Beam
lgtm
4 years, 3 months ago (2016-09-06 05:25:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311093002/20001
4 years, 3 months ago (2016-09-06 07:56:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 07:59:59 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 08:01:40 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9844d8891a6c83304ba67ca07e55b7c658e958e9
Cr-Commit-Position: refs/heads/master@{#416604}

Powered by Google App Engine
This is Rietveld 408576698