Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2311033002: [RuntimeCallStats] Fix reset scope for tracing (Closed)

Created:
4 years, 3 months ago by fmeawad
Modified:
4 years, 3 months ago
Reviewers:
lpy, Camillo Bruni, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[RuntimeCallStats] Fix reset scope for tracing https://codereview.chromium.org/2296243002/ introduced 2 minor bugs related to the Reset scope. The tracing version requires that we reset the counters everytime we start a new top level trace event, unless the top level one is not really a top level (i.e. has the right type but called in a nested way) Bugs are: 1- Reseting was guarded behind a check for the runtime call stats version only. 2- We never set that we are already inside a scope, so the nested case would fail as well. R=lpy@chromium.org, cbruni@chromium.org BUG=642373 Committed: https://crrev.com/5dd940082b1d876fff1c7dc50c9b4e378079049c Cr-Commit-Position: refs/heads/master@{#39214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
fmeawad
PTAL
4 years, 3 months ago (2016-09-05 20:12:37 UTC) #3
lpy
It seems to me that this bug will make the runtime call stats with tracing ...
4 years, 3 months ago (2016-09-05 20:54:54 UTC) #6
fmeawad
On 2016/09/05 20:54:54, lpy wrote: > It seems to me that this bug will make ...
4 years, 3 months ago (2016-09-05 21:36:28 UTC) #7
fmeawad
Adam, Can you check this small review?
4 years, 3 months ago (2016-09-06 14:59:46 UTC) #9
Camillo Bruni
lgtm
4 years, 3 months ago (2016-09-06 15:43:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311033002/1
4 years, 3 months ago (2016-09-06 15:46:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 15:48:14 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:48:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dd940082b1d876fff1c7dc50c9b4e378079049c
Cr-Commit-Position: refs/heads/master@{#39214}

Powered by Google App Engine
This is Rietveld 408576698