Object::GetElements() and friends maybehandlification.

test/cctest/test-heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 757 matching lines @@
 
   // Set array length to 0.
   JSArray::SetElementsLength(array, handle(Smi::FromInt(0), isolate)).Check();
   CHECK_EQ(Smi::FromInt(0), array->length());
   // Must be in fast mode.
   CHECK(array->HasFastSmiOrObjectElements());
 
   // array[length] = name.
   JSReceiver::SetElement(array, 0, name, NONE, SLOPPY).Check();
   CHECK_EQ(Smi::FromInt(1), array->length());
-  CHECK_EQ(*i::Object::GetElement(isolate, array, 0), *name);
+  CHECK_EQ(*i::Object::GetElement(isolate, array, 0).ToHandleChecked(), *name);
 
   // Set array length with larger than smi value.
   Handle<Object> length =
       factory->NewNumberFromUint(static_cast<uint32_t>(Smi::kMaxValue) + 1);
   JSArray::SetElementsLength(array, length).Check();
 
   uint32_t int_length = 0;
   CHECK(length->ToArrayIndex(&int_length));
   CHECK_EQ(*length, array->length());
   CHECK(array->HasDictionaryElements());  // Must be in slow mode.
 
   // array[length] = name.
   JSReceiver::SetElement(array, int_length, name, NONE, SLOPPY).Check();
   uint32_t new_int_length = 0;
   CHECK(array->length()->ToArrayIndex(&new_int_length));
   CHECK_EQ(static_cast<double>(int_length), new_int_length - 1);
-  CHECK_EQ(*i::Object::GetElement(isolate, array, int_length), *name);
-  CHECK_EQ(*i::Object::GetElement(isolate, array, 0), *name);
+  CHECK_EQ(*i::Object::GetElement(isolate, array, int_length).ToHandleChecked(),
+           *name);
+  CHECK_EQ(*i::Object::GetElement(isolate, array, 0).ToHandleChecked(), *name);
 }
 
 
 TEST(JSObjectCopy) {
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
 
   v8::HandleScope sc(CcTest::isolate());
   Handle<String> object_string(String::cast(CcTest::heap()->Object_string()));
@@ skipping 10 matching lines @@
   JSReceiver::SetProperty(obj, first, one, NONE, SLOPPY).Check();
   JSReceiver::SetProperty(obj, second, two, NONE, SLOPPY).Check();
 
   JSReceiver::SetElement(obj, 0, first, NONE, SLOPPY).Check();
   JSReceiver::SetElement(obj, 1, second, NONE, SLOPPY).Check();
 
   // Make the clone.
   Handle<JSObject> clone = JSObject::Copy(obj);
   CHECK(!clone.is_identical_to(obj));
 
-  CHECK_EQ(*i::Object::GetElement(isolate, obj, 0),
-           *i::Object::GetElement(isolate, clone, 0));
-  CHECK_EQ(*i::Object::GetElement(isolate, obj, 1),
-           *i::Object::GetElement(isolate, clone, 1));
+  CHECK_EQ(*i::Object::GetElement(isolate, obj, 0).ToHandleChecked(),
+           *i::Object::GetElement(isolate, clone, 0).ToHandleChecked());
+  CHECK_EQ(*i::Object::GetElement(isolate, obj, 1).ToHandleChecked(),
+           *i::Object::GetElement(isolate, clone, 1).ToHandleChecked());
 
   CHECK_EQ(*Object::GetProperty(obj, first),
            *Object::GetProperty(clone, first));
   CHECK_EQ(*Object::GetProperty(obj, second),
            *Object::GetProperty(clone, second));
 
   // Flip the values.
   JSReceiver::SetProperty(clone, first, two, NONE, SLOPPY).Check();
   JSReceiver::SetProperty(clone, second, one, NONE, SLOPPY).Check();
 
   JSReceiver::SetElement(clone, 0, second, NONE, SLOPPY).Check();
   JSReceiver::SetElement(clone, 1, first, NONE, SLOPPY).Check();
 
-  CHECK_EQ(*i::Object::GetElement(isolate, obj, 1),
-           *i::Object::GetElement(isolate, clone, 0));
-  CHECK_EQ(*i::Object::GetElement(isolate, obj, 0),
-           *i::Object::GetElement(isolate, clone, 1));
+  CHECK_EQ(*i::Object::GetElement(isolate, obj, 1).ToHandleChecked(),
+           *i::Object::GetElement(isolate, clone, 0).ToHandleChecked());
+  CHECK_EQ(*i::Object::GetElement(isolate, obj, 0).ToHandleChecked(),
+           *i::Object::GetElement(isolate, clone, 1).ToHandleChecked());
 
   CHECK_EQ(*Object::GetProperty(obj, second),
            *Object::GetProperty(clone, first));
   CHECK_EQ(*Object::GetProperty(obj, first),
            *Object::GetProperty(clone, second));
 }
 
 
 TEST(StringAllocation) {
   CcTest::InitializeVM();
@@ skipping 3076 matching lines @@
   v8::Context::Scope cscope(context);
 
   v8::Local<v8::Value> result = CompileRun(
       "var locals = '';"
       "for (var i = 0; i < 512; i++) locals += 'var v' + i + '= 42;';"
       "eval('function f() {' + locals + 'return function() { return v0; }; }');"
       "interrupt();"  // This triggers a fake stack overflow in f.
       "f()()");
   CHECK_EQ(42.0, result->ToNumber()->Value());
 }