Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2311003002: KeyLookupCache,DescriptorLookupCache: heap.h -> lookup.h (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

KeyLookupCache,DescriptorLookupCache: heap.h -> lookup.h R=ulan@chromium.org Committed: https://crrev.com/7f53dac6d94ef66de48a49fec629b7c3e9e0c498 Cr-Commit-Position: refs/heads/master@{#39185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -209 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -104 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -29 lines 0 comments Download
M src/isolate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/lookup.h View 1 chunk +101 lines, -0 lines 0 comments Download
M src/lookup.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A src/lookup-inl.h View 1 chunk +38 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
4 years, 3 months ago (2016-09-05 16:26:52 UTC) #3
ulan
lgtm
4 years, 3 months ago (2016-09-05 16:40:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311003002/1
4 years, 3 months ago (2016-09-05 17:27:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 17:28:45 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 17:29:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f53dac6d94ef66de48a49fec629b7c3e9e0c498
Cr-Commit-Position: refs/heads/master@{#39185}

Powered by Google App Engine
This is Rietveld 408576698