Issue 231093002: Do div-by-zero check for all gpus in ellipse/rr effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231093002: Do div-by-zero check for all gpus in ellipse/rr effects. (Closed)

Created:
6 years, 8 months ago by bsalomon

Modified:
6 years, 8 months ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Do div-by-zero check for all gpus in ellipse/rr effects. Committed: http://code.google.com/p/skia/source/detail?r=14110

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -16 lines)			Patch
M	src/gpu/GrOvalRenderer.cpp	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	src/gpu/effects/GrOvalEffect.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrRRectEffect.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

bsalomon

I wasn't sure if a similar change should be made for the distance field effect.

6 years, 8 months ago (2014-04-09 15:48:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/231093002/1

6 years, 8 months ago (2014-04-09 16:50:20 UTC) #4

Message was sent while issue was closed.

Change committed as 14110