Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2310903002: Revert of [regexp] Remove dead code (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Remove dead code (patchset #1 id:1 of https://codereview.chromium.org/2301803003/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Remove dead code > > Remove dead code, and drop the legacy RegExp.prototype.exec implementation (the > only differences are TO_BOOLEAN on global and sticky). > > BUG=v8:5339 > > Committed: https://crrev.com/1cb2a70cb5baa7545fdf9cc4e035a6d45cb189fd > Cr-Commit-Position: refs/heads/master@{#39121} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Committed: https://crrev.com/43a3912792e0a4d95d8c6f123122db2c0ca75c63 Cr-Commit-Position: refs/heads/master@{#39165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M src/js/regexp.js View 4 chunks +115 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of [regexp] Remove dead code
4 years, 3 months ago (2016-09-05 11:55:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310903002/1
4 years, 3 months ago (2016-09-05 11:55:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 12:29:32 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 12:29:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a3912792e0a4d95d8c6f123122db2c0ca75c63
Cr-Commit-Position: refs/heads/master@{#39165}

Powered by Google App Engine
This is Rietveld 408576698