dbus: No dbus::FileDescriptor in BluetoothProfileServiceProvider

dbus: No dbus::FileDescriptor in BluetoothProfileServiceProvider

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841
Committed: https://crrev.com/f64c34ead6bf89adcd3c16cc203add84be4323be
Cr-Commit-Position: refs/heads/master@{#417219}

[hashimoto, 2016-09-06 07:16:20]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 07:16:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 07:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 07:27:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hashimoto, 2016-09-06 08:18:50]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 08:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hashimoto, 2016-09-06 08:19:18]

hashimoto@chromium.org changed reviewers:
+ steel@chromium.org

[hashimoto, 2016-09-06 08:19:19]

PTL

[commit-bot: I haz the power, 2016-09-06 09:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 09:33:06]

Dry run: This issue passed the CQ dry run.

[Rahul Chaturvedi, 2016-09-06 23:01:20]

https://codereview.chromium.org/2310883003/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc (left):

https://codereview.chromium.org/2310883003/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc:105:
fd->CheckValidity();
We no longer care to check validity?

[hashimoto, 2016-09-07 05:55:17]

https://codereview.chromium.org/2310883003/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc (left):

https://codereview.chromium.org/2310883003/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc:105:
fd->CheckValidity();
On 2016/09/06 23:01:19, Rahul Chaturvedi wrote:
> We no longer care to check validity?

This "validity" check was introduced to avoid sending a directory FD to a Chrome
renderer process.
However, it turned out this check was not needed at all.
Please see http://crbug.com/621841 for the detail.

[Rahul Chaturvedi, 2016-09-07 21:17:53]

lgtm

[hashimoto, 2016-09-08 03:31:18]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2016-09-08 03:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 05:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 05:12:50]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[hashimoto, 2016-09-08 06:33:05]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2016-09-08 06:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:25:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 07:27:28]

Description was changed from

==========
dbus: No dbus::FileDescriptor in BluetoothProfileServiceProvider

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841
==========

to

==========
dbus: No dbus::FileDescriptor in BluetoothProfileServiceProvider

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841

Committed: https://crrev.com/f64c34ead6bf89adcd3c16cc203add84be4323be
Cr-Commit-Position: refs/heads/master@{#417219}
==========

[commit-bot: I haz the power, 2016-09-08 07:27:29]

Patchset 2 (id:??) landed as
https://crrev.com/f64c34ead6bf89adcd3c16cc203add84be4323be
Cr-Commit-Position: refs/heads/master@{#417219}